Conversation
|
Hi @craigtaverner, I've created a changelog YAML for you. |
f4adfab to
28c0641
Compare
f645590 to
7a59a68
Compare
dbe379c to
c7eb252
Compare
10c5744 to
9e81ef7
Compare
b716097 to
dc8d921
Compare
| * @return A warnings collector object | ||
| */ | ||
| // TODO: rename to createWarningsTreatedAsNull | ||
| public static Warnings createWarnings( |
There was a problem hiding this comment.
This is not a good paradigm. It caused a 400 file change. How about we provide a createWarnings that takes source in? Then the next time you need to pass something from the source it is a one file change and not 400 file change?
julian-elastic
left a comment
There was a problem hiding this comment.
Overall, still looks good with the latest changes. However, I would recommend fixing tech debt where passing something from source to warnings requires 400+ files change.
| clusterService.getClusterSettings().addSettingsUpdateConsumer(MAX_VIEWS_COUNT_SETTING, (i) -> this.maxViewsCount = i); | ||
| clusterService.getClusterSettings().addSettingsUpdateConsumer(MAX_VIEW_LENGTH_SETTING, (i) -> this.maxViewLength = i); | ||
| clusterService.getClusterSettings().addSettingsUpdateConsumer(MAX_VIEW_DEPTH_SETTING, (i) -> this.maxViewDepth = i); |
There was a problem hiding this comment.
NIT:
Instead of
this.something = SETTING.get(settings);
clusterService.getClusterSettings().addSettingsUpdateConsumer(SETTING, (i) -> this.something = i);
please use
clusterService.getClusterSettings().initializeAndWatch(SETTING, v -> this.something = v);
that takes care about both initialization and keeping the value updated.
There was a problem hiding this comment.
OK. I did this and simplified my use of settings in general.
…onstructor instead.
|
@craigtaverner according to this PR's labels, I need to update the changelog YAML, but I can't because the PR is closed. Please either update the changelog yourself on the appropriate branch, or adjust the labels. Specifically:
|
Initial support for ES|QL Views. It is based on the underlying sub-query support added in ..., and builds on the Views REST API work done in #137818.
Checklist: