Move individual stats fields to AsyncRefresh#135052
Merged
elasticsearchmachine merged 1 commit intoelastic:mainfrom Sep 19, 2025
Merged
Move individual stats fields to AsyncRefresh#135052elasticsearchmachine merged 1 commit intoelastic:mainfrom
elasticsearchmachine merged 1 commit intoelastic:mainfrom
Conversation
Only the overall ClusterInfo is needed at the top level. This PR moves the individual intermediate stats fields onto AsyncRefresh to avoid potential misuses. Relates: elastic#133630 (comment)
ywangd
added
:Distributed/Allocation
elasticsearchmachine
added
the
Team:Distributed Coordination (obsolete)
Collaborator
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
ywangd
added
the
auto-merge-without-approval
pxsalehi
added a commit
to pxsalehi/elasticsearch
that referenced
this pull request
Sep 24, 2025
This reverts commit 2b0153b.
pxsalehi
added a commit
to pxsalehi/elasticsearch
that referenced
this pull request
Sep 24, 2025
This reverts commit 2b0153b.
This was referenced Sep 24, 2025
DiannaHohensee
pushed a commit
that referenced
this pull request
Sep 24, 2025
DiannaHohensee
pushed a commit
that referenced
this pull request
Sep 24, 2025
* Revert "Move individual stats fields to AsyncRefresh (#135052)" This reverts commit 2b0153b. * Revert "Track shardStarted events for simulation in DesiredBalanceComputer (#133630)" This reverts commit f248596. * [CI] Update transport version definitions * Revert "[CI] Update transport version definitions" This reverts commit 90f38b0. * Don't reset upper bounds (#135226) Transport version upper bounds are currently set to their values from upstream main whenever no new definition is detected. However, this is like a partial merge of upstream, and produces broken state files. This commit temporarily comments out resetting until a more robust solution is built. * Revert "Don't reset upper bounds (#135226)" This reverts commit ddbac68. --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co> Co-authored-by: Ryan Ernst <ryan@iernst.net>
ywangd
added a commit
to ywangd/elasticsearch
that referenced
this pull request
Sep 29, 2025
This reverts commit e76d333.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 2, 2025
…mputer" (#135597) This PR reapplies both #133630 and #135052 with a performance bug fix. The original PR #133630 had a severe impact on throughput for index creation. It was reverted with #135369. The flamegraph suggests the system spent a lot time to compute shard assignments on ClusterInfo instantiation time. But that is unnecessary since they do not change within a single polling interval. This PR fixes it by reuse the last value and avoid recomputation. Copying the original commit message here If a shard starts on the target node before the next ClusterInfo polling, today we don't include it for the simulation. With this PR, we track shards that can potentially start within one ClusterInfo polling cycle so that they are always included in simulation. The tracking is reset when a new ClusterInfo arrives. Resolves: ES-12723
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only the overall ClusterInfo is needed at the top level. This PR moves the individual intermediate stats fields onto AsyncRefresh to avoid potential misuses.
Relates:
#133630 (comment)