Add 'profile' support for knn query on HNSW with early termination#135342
Merged
tteofili merged 12 commits intoelastic:mainfrom Sep 25, 2025
Merged
Add 'profile' support for knn query on HNSW with early termination#135342tteofili merged 12 commits intoelastic:mainfrom
tteofili merged 12 commits intoelastic:mainfrom
Conversation
Collaborator
|
Hi @tteofili, I've created a changelog YAML for you. |
…nto hnsw_et_profile
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
elasticsearchmachine
added
the
Team:Search Relevance
benwtrent
reviewed
Sep 24, 2025
Member
benwtrent
left a comment
benwtrent
left a comment
There was a problem hiding this comment.
Do you think this can work with ESDiversifyingChildren*KnnVectorQuery objects as well? I would expect it to work OK as we still delegate to the underlying collector.
Or did you test it and it not provide good results?
server/src/main/java/org/elasticsearch/search/vectors/PatienceCollectorManager.java
Outdated
Show resolved
Hide resolved
Contributor
Author
yes, it works also with diversifying knn query (had run benchmarks in the original PR too), I've fixed this in 53cfeb5. |
benwtrent
approved these changes
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup to #127223 that leverages some changes in Lucene 10.3 to extend and reuse
HnswQueueSaturationCollectorto simplify code in ES for early termination on HNSW.Very importantly, it also adds 'profile' support so that
vector_opsare now correctly recorded also when early termination is enabled.