ESQL: take INLINE STATS out of snapshot#135403
Merged
astefan merged 8 commits intoelastic:mainfrom Sep 26, 2025
Merged
Conversation
astefan
added
test-release
Collaborator
|
Hi @astefan, I've created a changelog YAML for you. |
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
bpintea
approved these changes
Sep 25, 2025
Contributor
bpintea
left a comment
bpintea
left a comment
There was a problem hiding this comment.
LGTM.
My only concern is the many assumeTrue("INLINE STATS must be enabled", INLINE_STATS.isEnabled()); we have in unit test code. Those will stay now, but we might add more capabilities and this check and capability will probably remain a bit behind. But anyways, that can be a subsequent step, if at all.
|
|
||
| // INLINE STATS is under development, we enable this once it will be available | ||
| forkBeforeInlineStats-Ignore | ||
| forkBeforeInlineStats |
Contributor
Author
|
@bpintea indeed, I debated if I should remove them altogether or not. Eventually, I decided to leave them as is for some time (after the feature proves itself useful hopefully) and then clean everything up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.