[ES|QL] Optimize vector similarity when one param is constant by pmpailis · Pull Request #135602 · elastic/elasticsearch

pmpailis · 2025-09-29T09:30:25Z

This PR aims to optimize the way we handle constant vectors in ES|QL vector similarity functions. The main idea is to reuse a single object and avoid duplicating and creating huge FloatBlock instances and identical float arrays.

Benchmark results show a nice improvement for the script-score functions using the so_vector rally track:

| Metric                                      | Main (ms) | Candidate (ms) | Δ% (Candidate vs Main) |
|---------------------------------------------|-----------|----------------|-------------------------|
| esql-script-score-query-match-all            | 6528.64   | 2567.18        | -60.7%                 |
| esql-script-score-query-acceptedAnswerId     | 6388.91   | 2171.75        | -66.0%                 |
| esql-script-score-query-java                 | 714.05    | 261.21         | -63.4%                 |
| esql-script-score-query-javascript           | 594.97    | 212.74         | -64.3%                 |
| esql-script-score-query-css                  | 226.48    | 86.48          | -61.8%                 |
| esql-script-score-query-concurrency          | 23.44     | 13.06          | -44.3%                 |

Closes #134210

…ctor_similarity_when_constant

…github.com:pmpailis/elasticsearch into pb_134210_optimize_vector_similarity_when_constant

carlosdelest

This LGTM - a question about creating multiple subclasses

carlosdelest · 2025-09-29T18:58:28Z

...n/java/org/elasticsearch/xpack/esql/expression/function/vector/VectorSimilarityFunction.java

    public final EvalOperator.ExpressionEvaluator.Factory toEvaluator(EvaluatorMapper.ToEvaluator toEvaluator) {
+        VectorValueProvider.Builder leftVectorProviderBuilder = new VectorValueProvider.Builder();
+        VectorValueProvider.Builder rightVectorProviderBuilder = new VectorValueProvider.Builder();
+        if (left() instanceof Literal && left().dataType() == DENSE_VECTOR) {


I think you can count on the arguments being type dense_vector, it is already checked as part of checkDenseVectorParam() and would have been caught at the Analyzer level

carlosdelest · 2025-09-29T19:02:02Z

...n/java/org/elasticsearch/xpack/esql/expression/function/vector/VectorSimilarityFunction.java

+        private FloatBlock block;
+        private float[] scratch;
+
+        VectorValueProvider(ArrayList<Float> constantVector, EvalOperator.ExpressionEvaluator expressionEvaluator) {


Good idea to use a class to wrap the different ways of retrieving vectors!

Would it make sense to create two separate subclasses, so we don't need to keep checking for what has been provided?

That's a nice suggestion and will make things easier to follow, thanks! Will refactor to have 2 subclasses.

…nstant

elasticsearchmachine · 2025-10-01T08:45:59Z

Pinging @elastic/es-search-relevance (Team:Search Relevance)

pmpailis · 2025-10-01T09:21:29Z

...icsearch/xpack/esql/expression/function/vector/AbstractVectorSimilarityFunctionTestCase.java

        assumeTrue("Similarity function is not enabled", capability().isEnabled());
    }

+    public abstract String getBaseEvaluatorName();


@carlosdelest trying to find a better way to access this as we already pass it in the similarityParameters , but it was getting a bit too complicated for a small-scoped change, as the PR only affects the similarity functions. Happy to discuss alternatives :)

pmpailis · 2025-10-01T10:08:49Z

run elasticsearch-ci/part-3

…nstant

carlosdelest · 2025-10-01T12:53:55Z

x-pack/plugin/esql-core/src/main/java/org/elasticsearch/xpack/esql/core/type/DataType.java


    /**
-     * Fields with this type are dense vectors, represented as an array of double values.
+     * Fields with this type are dense vectors, represented as an array of float values.


😁 thanks for fixing!

carlosdelest · 2025-10-01T13:16:49Z

...n/java/org/elasticsearch/xpack/esql/expression/function/vector/VectorSimilarityFunction.java

+        }
+
+        @Override
+        public String toString() {


What do you think about creating a different factory for each type of VectorValueProvider, both of them implementing the same interface?

That would help with not having to check which of the two fields need to be used. Each of the classes would have its build() and toString() methods.

I think it makes sense as the factories create two different objects - makes sense to make them different.

Maybe it¡s a bit convoluted for what we're doing but probably cleaner. WDYT?

++ makes sense. Didn't want to have a ton of new factories/interfaces, but it will be cleaner. Will refactor as suggested.

Updated in ee019f2

…github.com:pmpailis/elasticsearch into pb_134210_optimize_vector_similarity_when_constant

carlosdelest

Great work! Your first PR achieved such a speedup 🚀

carlosdelest · 2025-10-02T10:09:48Z

...n/java/org/elasticsearch/xpack/esql/expression/function/vector/VectorSimilarityFunction.java

    public final EvalOperator.ExpressionEvaluator.Factory toEvaluator(EvaluatorMapper.ToEvaluator toEvaluator) {
+        VectorValueProviderFactory leftVectorProviderFactory;
+        VectorValueProviderFactory rightVectorProviderFactory;
+        if (left() instanceof Literal) {


Nit - we could extract this to a private method

++ updated in 9f47ab2

pmpailis added 8 commits September 26, 2025 15:06

iter

7d9e975

iter

abe7f01

iter

989235e

iter

aeebc6e

iter

240dd53

iter

4a759ba

Merge remote-tracking branch 'origin/main' into pb_134210_optimize_ve…

e386b62

…ctor_similarity_when_constant

iter

0301c5b

pmpailis added >non-issue :Search Relevance/ES|QL Search functionality in ES|QL labels Sep 29, 2025

elasticsearchmachine added the v9.2.0 label Sep 29, 2025

pmpailis and others added 8 commits September 29, 2025 12:48

Merge remote-tracking branch 'origin/main' into pb_134210_optimize_ve…

97d1958

…ctor_similarity_when_constant

[CI] Auto commit changes from spotless

cafafcb

iter

9f12dbe

Merge branch 'pb_134210_optimize_vector_similarity_when_constant' of …

3509bba

…github.com:pmpailis/elasticsearch into pb_134210_optimize_vector_similarity_when_constant

checkstyle

1fc70a2

[CI] Auto commit changes from spotless

7b5b760

checkstyle

9d51231

checkstyle

504c92e

carlosdelest reviewed Sep 29, 2025

View reviewed changes

pmpailis added 4 commits September 30, 2025 16:16

iter

59cdda9

iter

6da8fb4

iter

42dcf15

Merge branch 'main' into pb_134210_optimize_vector_similarity_when_co…

c336ede

…nstant

pmpailis marked this pull request as ready for review October 1, 2025 08:45

elasticsearchmachine added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Oct 1, 2025

pmpailis and others added 3 commits October 1, 2025 11:46

iter

4640bb8

adding test cases for toString when one vector is a literal

8d72e5c

[CI] Auto commit changes from spotless

c25f0bd

pmpailis commented Oct 1, 2025

View reviewed changes

Merge branch 'main' into pb_134210_optimize_vector_similarity_when_co…

5d95e16

…nstant

elasticsearchmachine added v9.3.0 and removed v9.2.0 labels Oct 2, 2025

carlosdelest reviewed Oct 2, 2025

View reviewed changes

pmpailis added 2 commits October 2, 2025 12:55

addressing PR comments - adding common factory interface

ee019f2

Merge branch 'pb_134210_optimize_vector_similarity_when_constant' of …

96c1a53

…github.com:pmpailis/elasticsearch into pb_134210_optimize_vector_similarity_when_constant

carlosdelest approved these changes Oct 2, 2025

View reviewed changes

extracting method for generating the appropriate factory

9f47ab2

pmpailis enabled auto-merge (squash) October 2, 2025 11:07

pmpailis merged commit abf225c into elastic:main Oct 2, 2025
34 checks passed

GalLalouche mentioned this pull request Oct 10, 2025

ESQL: Vector similarity ClassCastException on 1-dimension literal vector #136364

Closed

pmpailis mentioned this pull request Oct 21, 2025

[ES|QL] fixing bug when handling 1d literal vectors #136891

Merged

pmpailis deleted the pb_134210_optimize_vector_similarity_when_constant branch January 16, 2026 15:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ES|QL] Optimize vector similarity when one param is constant#135602

[ES|QL] Optimize vector similarity when one param is constant#135602
pmpailis merged 27 commits intoelastic:mainfrom
pmpailis:pb_134210_optimize_vector_similarity_when_constant

pmpailis commented Sep 29, 2025 •

edited

Loading

carlosdelest left a comment

carlosdelest Sep 29, 2025

carlosdelest Sep 29, 2025

pmpailis Sep 29, 2025

elasticsearchmachine commented Oct 1, 2025

pmpailis Oct 1, 2025

pmpailis commented Oct 1, 2025

carlosdelest Oct 1, 2025

carlosdelest Oct 1, 2025

pmpailis Oct 2, 2025

pmpailis Oct 2, 2025

carlosdelest left a comment

carlosdelest Oct 2, 2025

pmpailis Oct 2, 2025

Uh oh!

Labels

3 participants

Conversation

pmpailis commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

carlosdelest left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elasticsearchmachine commented Oct 1, 2025

Choose a reason for hiding this comment

pmpailis commented Oct 1, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

carlosdelest left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Uh oh!

Labels

3 participants

pmpailis commented Sep 29, 2025 •

edited

Loading