ES|QL: support dot and parameters in FUSE GROUP BY#135901
Merged
luigidellaquila merged 9 commits intoelastic:mainfrom Oct 3, 2025
Merged
ES|QL: support dot and parameters in FUSE GROUP BY#135901luigidellaquila merged 9 commits intoelastic:mainfrom
luigidellaquila merged 9 commits intoelastic:mainfrom
Conversation
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Collaborator
|
Hi @luigidellaquila, I've created a changelog YAML for you. |
…o esql/fuse_with_dot
ioanatia
approved these changes
Oct 3, 2025
leemthompo
reviewed
Oct 3, 2025
Contributor
leemthompo
left a comment
There was a problem hiding this comment.
I just have a tiny nitty suggestion on the changelog summary :)
Co-authored-by: Liam Thompson <leemthompo@gmail.com>
1 task
sddonne
added a commit
to elastic/kibana
that referenced
this pull request
Oct 6, 2025
Part of #236938 ## Summary This PR adds `AST` support for the new`FUSE` parameters. ``` fuseCommand : DEV_FUSE (fuseType=identifier)? (fuseConfiguration)* ; fuseConfiguration : SCORE BY score=qualifiedName | KEY BY key=fields | GROUP BY group=qualifiedName | WITH options=mapExpression ; ``` `FUSE <fuse_method> SCORE BY <score_column> GROUP BY <group_column> KEY BY <key_columns> WITH <options>` ### Some Examples `| FUSE LINEAR # Merge results using linear combination of scores (equal weights by default)` `| FUSE LINEAR WITH { "normalizer": "minmax" } # Linear combination with min-max normalization (scales scores to 0-1 range) ` `| FUSE LINEAR WITH { "weights": { "fork1": 0.7, "fork2": 0.3 }, "normalizer": "minmax" } # Weighted linear combination: 70% lexical, 30% semantic, with min-max normalization` ### Note No tests has been added to check parameters or fields with dots, as the parser needs this [fix](elastic/elasticsearch#135901) to be merged to support them. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
rylnd
pushed a commit
to rylnd/kibana
that referenced
this pull request
Oct 17, 2025
Part of elastic#236938 ## Summary This PR adds `AST` support for the new`FUSE` parameters. ``` fuseCommand : DEV_FUSE (fuseType=identifier)? (fuseConfiguration)* ; fuseConfiguration : SCORE BY score=qualifiedName | KEY BY key=fields | GROUP BY group=qualifiedName | WITH options=mapExpression ; ``` `FUSE <fuse_method> SCORE BY <score_column> GROUP BY <group_column> KEY BY <key_columns> WITH <options>` ### Some Examples `| FUSE LINEAR # Merge results using linear combination of scores (equal weights by default)` `| FUSE LINEAR WITH { "normalizer": "minmax" } # Linear combination with min-max normalization (scales scores to 0-1 range) ` `| FUSE LINEAR WITH { "weights": { "fork1": 0.7, "fork2": 0.3 }, "normalizer": "minmax" } # Weighted linear combination: 70% lexical, 30% semantic, with min-max normalization` ### Note No tests has been added to check parameters or fields with dots, as the parser needs this [fix](elastic/elasticsearch#135901) to be merged to support them. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for parameters and for dots in attribute names used by FUSE command, eg.
The problem was just missing trokens in the lexer definition for FUSE