Skip to content

Adding match_only_text subfield to *.display_name fields#136265

Merged
felixbarny merged 10 commits intoelastic:mainfrom
eyalkoren:ecs@mappings-display_name
Oct 13, 2025
Merged

Adding match_only_text subfield to *.display_name fields#136265
felixbarny merged 10 commits intoelastic:mainfrom
eyalkoren:ecs@mappings-display_name

Conversation

@eyalkoren
Copy link
Contributor

Changing ecs@mappings to match the new ECS definitions that were added in elastic/ecs#2547.
*.display_name fields were already mapped as keyword, but this PR adds a match_only_text subfield called text.

@eyalkoren eyalkoren requested a review from felixbarny October 9, 2025 09:31
@eyalkoren eyalkoren self-assigned this Oct 9, 2025
@eyalkoren eyalkoren added >feature :StorageEngine/Data streams Data streams and their lifecycles v9.3.0 labels Oct 9, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Data Management (obsolete) DO NOT USE. This team no longer exists. label Oct 9, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine
Copy link
Collaborator

Hi @eyalkoren, I've created a changelog YAML for you.

eyalkoren and others added 2 commits October 9, 2025 18:09
Co-authored-by: Felix Barnsteiner <felixbarny@users.noreply.github.com>
@eyalkoren
Copy link
Contributor Author

@mjwolf can you tell what these serverless test failures are about?

@eyalkoren eyalkoren enabled auto-merge (squash) October 9, 2025 16:44
@felixbarny
Copy link
Member

Oh, I think we have to increment the version in the stack template registry.

@dakrone
Copy link
Member

dakrone commented Oct 9, 2025

Yes, that will need to be incremented.

@dakrone dakrone disabled auto-merge October 9, 2025 17:10
@mjwolf
Copy link

mjwolf commented Oct 9, 2025

@mjwolf can you tell what these serverless test failures are about?

I'm not sure what serverless test failures you're referring to?

@dakrone
Copy link
Member

dakrone commented Oct 9, 2025

I'm not sure what serverless test failures you're referring to?

There were some transient compilation failures that were unrelated to this change, in the ML project. They're gone after merging master.

@eyalkoren
Copy link
Contributor Author

Right, the registry version 🙁
I really wish there was a way to stop relying on this manual versioning.
How about relying on a combined hash of all templates instead to decide whether templates need to be upgraded?

@eyalkoren
Copy link
Contributor Author

Again serverless build fail with unrelated error, but this time branch update doesn't help 🙁

@felixbarny
Copy link
Member

I really wish there was a way to stop relying on this manual versioning.
How about relying on a combined hash of all templates instead to decide whether templates need to be upgraded?

I also always forget to increment the version, and I agree that we should do something about it.

I like your idea. Building on that, I had another one that maybe requires fewer changes. In addition to the version constant, we'd also add a string constant, holding the hash of all templates in a registry. We could make tests fail if the hashes differ which forces you to update the hash, acting as a reminder to increment the version.

Not sure which option I like better. But IIRC, Jimmy's template bulk API idea might change this again so maybe a more incremental improvement makes sense?

@felixbarny felixbarny merged commit 7567848 into elastic:main Oct 13, 2025
34 checks passed
georgewallace pushed a commit to georgewallace/elasticsearch that referenced this pull request Oct 13, 2025
…#136265)

---------

Co-authored-by: Felix Barnsteiner <felixbarny@users.noreply.github.com>
Co-authored-by: Lee Hinman <dakrone@users.noreply.github.com>
@eyalkoren
Copy link
Contributor Author

In addition to the version constant, we'd also add a string constant, holding the hash of all templates in a registry. We could make tests fail if the hashes differ which forces you to update the hash, acting as a reminder to increment the version.

That's a nice idea! It means that every change would result in a version increment (instead of once per release), but I don't think that's an issue.

@eyalkoren
Copy link
Contributor Author

Here it is: #136666

Kubik42 pushed a commit to Kubik42/elasticsearch that referenced this pull request Oct 16, 2025
…#136265)

---------

Co-authored-by: Felix Barnsteiner <felixbarny@users.noreply.github.com>
Co-authored-by: Lee Hinman <dakrone@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>feature :StorageEngine/Data streams Data streams and their lifecycles Team:Data Management (obsolete) DO NOT USE. This team no longer exists. v9.3.0

5 participants