Adding match_only_text subfield to *.display_name fields#136265
Adding match_only_text subfield to *.display_name fields#136265felixbarny merged 10 commits intoelastic:mainfrom
match_only_text subfield to *.display_name fields#136265Conversation
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
Hi @eyalkoren, I've created a changelog YAML for you. |
Co-authored-by: Felix Barnsteiner <felixbarny@users.noreply.github.com>
|
@mjwolf can you tell what these serverless test failures are about? |
|
Oh, I think we have to increment the version in the stack template registry. |
|
Yes, that will need to be incremented. |
I'm not sure what serverless test failures you're referring to? |
There were some transient compilation failures that were unrelated to this change, in the ML project. They're gone after merging master. |
|
Right, the registry version 🙁 |
…to ecs@mappings-display_name
|
Again serverless build fail with unrelated error, but this time branch update doesn't help 🙁 |
I also always forget to increment the version, and I agree that we should do something about it. I like your idea. Building on that, I had another one that maybe requires fewer changes. In addition to the version constant, we'd also add a string constant, holding the hash of all templates in a registry. We could make tests fail if the hashes differ which forces you to update the hash, acting as a reminder to increment the version. Not sure which option I like better. But IIRC, Jimmy's template bulk API idea might change this again so maybe a more incremental improvement makes sense? |
…#136265) --------- Co-authored-by: Felix Barnsteiner <felixbarny@users.noreply.github.com> Co-authored-by: Lee Hinman <dakrone@users.noreply.github.com>
That's a nice idea! It means that every change would result in a version increment (instead of once per release), but I don't think that's an issue. |
|
Here it is: #136666 |
…#136265) --------- Co-authored-by: Felix Barnsteiner <felixbarny@users.noreply.github.com> Co-authored-by: Lee Hinman <dakrone@users.noreply.github.com>
Changing
ecs@mappingsto match the new ECS definitions that were added in elastic/ecs#2547.*.display_namefields were already mapped askeyword, but this PR adds amatch_only_textsubfield calledtext.