ES|QL: fix Page.equals()#136266
Merged
luigidellaquila merged 7 commits intoelastic:mainfrom Oct 9, 2025
Merged
Conversation
elasticsearchmachine
added
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Collaborator
|
Hi @luigidellaquila, I've created a changelog YAML for you. |
alex-spies
approved these changes
Oct 9, 2025
ivancea
approved these changes
Oct 9, 2025
Contributor
ivancea
left a comment
ivancea
left a comment
There was a problem hiding this comment.
LGTM! Do we know the reason why it was like that?
idegtiarenko
approved these changes
Oct 9, 2025
Contributor
Author
|
Thanks folks!
I tracked it back to a commit from Feb 2023 and I briefly discussed it with Chris. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two pages with
positionCount=0should be considered not equal if they have different number/type of blocks.This change also makes
equals()coherent withhashCode(), that already accounted for blocksFixes: #135977
Fixes: #135990