Store full path in _ignored when ignoring dynamic array field#136315
Merged
jordan-powers merged 2 commits intoelastic:mainfrom Oct 9, 2025
Merged
Conversation
jordan-powers
added
>bug
Team:StorageEngine
:StorageEngine/Mapping
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Collaborator
|
Hi @jordan-powers, I've created a changelog YAML for you. |
jordan-powers
added
auto-backport
parkertimmins
approved these changes
Oct 9, 2025
Contributor
parkertimmins
left a comment
parkertimmins
left a comment
There was a problem hiding this comment.
Looks good to me. Nice find!
jordan-powers
added a commit
to jordan-powers/elasticsearch
that referenced
this pull request
Oct 9, 2025
…c#136315) Currently, when a dynamic array field trips `index.mapping.total_fields. limit` and is ignored due to `index.mapping.total_fields. ignore_dynamic_beyond_limit`, the leaf name is stored in _ignored. This is inconsistent with single-valued fields where the full path is stored in _ignored. This PR updates the logic so that in both cases, the full path is stored.
This was referenced Oct 9, 2025
Collaborator
jordan-powers
added a commit
to jordan-powers/elasticsearch
that referenced
this pull request
Oct 9, 2025
…c#136315) Currently, when a dynamic array field trips `index.mapping.total_fields. limit` and is ignored due to `index.mapping.total_fields. ignore_dynamic_beyond_limit`, the leaf name is stored in _ignored. This is inconsistent with single-valued fields where the full path is stored in _ignored. This PR updates the logic so that in both cases, the full path is stored.
jordan-powers
added a commit
to jordan-powers/elasticsearch
that referenced
this pull request
Oct 9, 2025
…c#136315) Currently, when a dynamic array field trips `index.mapping.total_fields. limit` and is ignored due to `index.mapping.total_fields. ignore_dynamic_beyond_limit`, the leaf name is stored in _ignored. This is inconsistent with single-valued fields where the full path is stored in _ignored. This PR updates the logic so that in both cases, the full path is stored.
jordan-powers
added a commit
to jordan-powers/elasticsearch
that referenced
this pull request
Oct 9, 2025
…c#136315) Currently, when a dynamic array field trips `index.mapping.total_fields. limit` and is ignored due to `index.mapping.total_fields. ignore_dynamic_beyond_limit`, the leaf name is stored in _ignored. This is inconsistent with single-valued fields where the full path is stored in _ignored. This PR updates the logic so that in both cases, the full path is stored.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 9, 2025
… (#136326) Currently, when a dynamic array field trips `index.mapping.total_fields. limit` and is ignored due to `index.mapping.total_fields. ignore_dynamic_beyond_limit`, the leaf name is stored in _ignored. This is inconsistent with single-valued fields where the full path is stored in _ignored. This PR updates the logic so that in both cases, the full path is stored.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 9, 2025
… (#136325) Currently, when a dynamic array field trips `index.mapping.total_fields. limit` and is ignored due to `index.mapping.total_fields. ignore_dynamic_beyond_limit`, the leaf name is stored in _ignored. This is inconsistent with single-valued fields where the full path is stored in _ignored. This PR updates the logic so that in both cases, the full path is stored.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 9, 2025
… (#136324) Currently, when a dynamic array field trips `index.mapping.total_fields. limit` and is ignored due to `index.mapping.total_fields. ignore_dynamic_beyond_limit`, the leaf name is stored in _ignored. This is inconsistent with single-valued fields where the full path is stored in _ignored. This PR updates the logic so that in both cases, the full path is stored.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 9, 2025
… (#136323) Currently, when a dynamic array field trips `index.mapping.total_fields. limit` and is ignored due to `index.mapping.total_fields. ignore_dynamic_beyond_limit`, the leaf name is stored in _ignored. This is inconsistent with single-valued fields where the full path is stored in _ignored. This PR updates the logic so that in both cases, the full path is stored.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 9, 2025
… (#136322) Currently, when a dynamic array field trips `index.mapping.total_fields. limit` and is ignored due to `index.mapping.total_fields. ignore_dynamic_beyond_limit`, the leaf name is stored in _ignored. This is inconsistent with single-valued fields where the full path is stored in _ignored. This PR updates the logic so that in both cases, the full path is stored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when a dynamic array field trips
index.mapping.total_fields.limitand is ignored due toindex.mapping.total_fields.ignore_dynamic_beyond_limit, the leaf name is stored in_ignored.This is inconsistent with single-valued fields where the full path is stored in
_ignored:elasticsearch/server/src/main/java/org/elasticsearch/index/mapper/DocumentParserContext.java
Line 555 in c0f15d6
This PR updates the logic so that in both cases, the full path is stored.