Skip to content

Bugfix 136545#136556

Merged
benwtrent merged 4 commits intoelastic:mainfrom
benwtrent:bugfix-136545
Oct 14, 2025
Merged

Bugfix 136545#136556
benwtrent merged 4 commits intoelastic:mainfrom
benwtrent:bugfix-136545

Conversation

@benwtrent
Copy link
Member

Sometimes, when the _source is empty, the underlying code will return Map.of() which is immutable. We don't really have an isImmutable() flag for Java objects (I mean...why not??), so I defaulted to assuming isEmpty() implies immutable and we create a new ordered map.

closes: #136545

@benwtrent benwtrent added >bug auto-backport Automatically create backport pull requests when merged :Search Relevance/Vectors Vector search v9.2.1 v9.3.0 labels Oct 14, 2025
@benwtrent benwtrent requested a review from jimczi October 14, 2025 16:59
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@elasticsearchmachine elasticsearchmachine added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Oct 14, 2025
@elasticsearchmachine
Copy link
Collaborator

Hi @benwtrent, I've created a changelog YAML for you.

Copy link
Contributor

@john-wagster john-wagster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@benwtrent benwtrent merged commit 69774c2 into elastic:main Oct 14, 2025
34 checks passed
@benwtrent benwtrent deleted the bugfix-136545 branch October 14, 2025 18:36
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
9.2 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 136556

@benwtrent
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
9.2

Questions ?

Please refer to the Backport tool documentation

benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Oct 14, 2025
* Address UOE on exclude vectors field fetching

* removing unnecessary chagne

* iter

* Update docs/changelog/136556.yaml

(cherry picked from commit 69774c2)
elasticsearchmachine pushed a commit that referenced this pull request Oct 14, 2025
* Address UOE on exclude vectors field fetching

* removing unnecessary chagne

* iter

* Update docs/changelog/136556.yaml

(cherry picked from commit 69774c2)
Kubik42 pushed a commit to Kubik42/elasticsearch that referenced this pull request Oct 16, 2025
* Address UOE on exclude vectors field fetching

* removing unnecessary chagne

* iter

* Update docs/changelog/136556.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged backport pending >bug :Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.2.1 v9.3.0

3 participants