Lazy compute and cache grantsAll per privilege#136684
Merged
slobodanadamovic merged 2 commits intoelastic:mainfrom Oct 16, 2025
Merged
Lazy compute and cache grantsAll per privilege#136684slobodanadamovic merged 2 commits intoelastic:mainfrom
grantsAll per privilege#136684slobodanadamovic merged 2 commits intoelastic:mainfrom
Conversation
This change avoids calling expensive `Operations.isTotal` every time an application privilege is checked. This is done by caching the result per privilege. It avoids re-building privilege's automaton each time upstream `ApplicationPermission#grants` is called.
slobodanadamovic
added
:Security/Authorization
Collaborator
|
Pinging @elastic/es-security (Team:Security) |
Collaborator
|
Hi @slobodanadamovic, I've created a changelog YAML for you. |
jfreden
approved these changes
Oct 16, 2025
Contributor
jfreden
left a comment
jfreden
left a comment
There was a problem hiding this comment.
LGTM! Great improvement! 🚀
slobodanadamovic
added a commit
to slobodanadamovic/elasticsearch
that referenced
this pull request
Oct 16, 2025
This change avoids calling expensive `Operations.isTotal` every time an application privilege is checked. This is done by caching the result per privilege. It avoids re-building privilege's automaton each time upstream `ApplicationPermission#grants` gets called.
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
slobodanadamovic
added a commit
to slobodanadamovic/elasticsearch
that referenced
this pull request
Oct 16, 2025
This change avoids calling expensive `Operations.isTotal` every time an application privilege is checked. This is done by caching the result per privilege. It avoids re-building privilege's automaton each time upstream `ApplicationPermission#grants` gets called.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 16, 2025
This change avoids calling expensive `Operations.isTotal` every time an application privilege is checked. This is done by caching the result per privilege. It avoids re-building privilege's automaton each time upstream `ApplicationPermission#grants` gets called.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 16, 2025
This change avoids calling expensive `Operations.isTotal` every time an application privilege is checked. This is done by caching the result per privilege. It avoids re-building privilege's automaton each time upstream `ApplicationPermission#grants` gets called.
slobodanadamovic
added a commit
that referenced
this pull request
Oct 16, 2025
This change avoids calling expensive `Operations.isTotal` every time an application privilege is checked. This is done by caching the result per privilege. It avoids re-building privilege's automaton each time upstream `ApplicationPermission#grants` gets called. (cherry picked from commit 0b6338a) # Conflicts: # x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/security/authz/privilege/Privilege.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 16, 2025
This change avoids calling expensive `Operations.isTotal` every time an application privilege is checked. This is done by caching the result per privilege. It avoids re-building privilege's automaton each time upstream `ApplicationPermission#grants` gets called. (cherry picked from commit 0b6338a) # Conflicts: # x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/security/authz/privilege/Privilege.java
Kubik42
pushed a commit
to Kubik42/elasticsearch
that referenced
this pull request
Oct 16, 2025
This change avoids calling expensive `Operations.isTotal` every time an application privilege is checked. This is done by caching the result per privilege. It avoids re-building privilege's automaton each time upstream `ApplicationPermission#grants` gets called.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change avoids calling expensive
Operations.isTotaleverytime an application privilege is checked. This is done by caching
the result per privilege. It avoids re-building privilege's automaton
each time upstream
ApplicationPermission#grantsgets called.