Fix log formatting in SnapshotLifecycleTask#136709
Merged
nielsbauman merged 2 commits intoelastic:mainfrom Oct 17, 2025
Merged
Conversation
While converting an error log from `logger.error` to `logger.error(format())` in elastic#131646, we forgot to update the syntax from `{}` to `%s`. This resulted in the logs `failed to create snapshot for snapshot lifecycle policy [{}]`. This commit fixes the syntax and ensures we use the right logger.
nielsbauman
added
>bug
:Data Management/ILM+SLM
elasticsearchmachine
added
v9.3.0
Team:Data Management (obsolete)
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
Collaborator
|
Hi @nielsbauman, I've created a changelog YAML for you. |
szybia
approved these changes
Oct 17, 2025
Contributor
szybia
left a comment
szybia
left a comment
There was a problem hiding this comment.
lgmt, but should we also add/fix this in 9.2.1?
nielsbauman
added
auto-backport
Collaborator
💚 Backport successful
|
nielsbauman
added a commit
to nielsbauman/elasticsearch
that referenced
this pull request
Oct 17, 2025
While converting an error log from `logger.error` to `logger.error(format())` in elastic#131646, we forgot to update the syntax from `{}` to `%s`. This resulted in the logs `failed to create snapshot for snapshot lifecycle policy [{}]`. This commit fixes the syntax and ensures we use the right logger.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 17, 2025
While converting an error log from `logger.error` to `logger.error(format())` in #131646, we forgot to update the syntax from `{}` to `%s`. This resulted in the logs `failed to create snapshot for snapshot lifecycle policy [{}]`. This commit fixes the syntax and ensures we use the right logger.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While converting an error log from
logger.errortologger.error(format())in #131646, we forgot to update the syntax from{}to%s. This resulted in the logsfailed to create snapshot for snapshot lifecycle policy [{}]. This commit fixes the syntax and ensures we use the right logger.