Address CompoundRetrieverBuilder Failure Handling#136732
Merged
john-wagster merged 26 commits intoelastic:mainfrom Dec 13, 2025
Merged
Address CompoundRetrieverBuilder Failure Handling#136732john-wagster merged 26 commits intoelastic:mainfrom
john-wagster merged 26 commits intoelastic:mainfrom
Conversation
john-wagster
commented
Oct 17, 2025
server/src/main/java/org/elasticsearch/search/retriever/CompoundRetrieverBuilder.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@pmpailis curious if this is roughly what you were thinking in terms of improving error handling and if you had other thoughts about how this should behave or additional checks. What else would be nice to have here? I thought about enhancing the error message handling within the |
pmpailis
reviewed
Oct 17, 2025
server/src/main/java/org/elasticsearch/search/retriever/CompoundRetrieverBuilder.java
Outdated
Show resolved
Hide resolved
pmpailis
reviewed
Oct 17, 2025
server/src/main/java/org/elasticsearch/search/retriever/CompoundRetrieverBuilder.java
Outdated
Show resolved
Hide resolved
Contributor
|
Thanks @john-wagster for picking this up! ❤️ Yeah, this is pretty much what I was thinking as well; only minor comments on the type of exception that we would throw (to avoid constantly 5xx). Will take a look at adding a test case as well. |
john-wagster
added
:Search Relevance/Search
elasticsearchmachine
added
the
Team:Search Relevance
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
john-wagster
added
>bug
and removed
Team:Search Relevance
elasticsearchmachine
added
the
Team:Search Relevance
Collaborator
|
Hi @john-wagster, I've created a changelog YAML for you. |
john-wagster
added
v9.2.1
v9.1.6
and removed
Team:Search Relevance
elasticsearchmachine
added
the
Team:Search Relevance
…:john-wagster/elasticsearch into better_retriever_errors_on_shard_failure
…lowed for compound retrievers
…:john-wagster/elasticsearch into better_retriever_errors_on_shard_failure
pmpailis
reviewed
Dec 12, 2025
...rrf/src/internalClusterTest/java/org/elasticsearch/xpack/rank/rrf/RRFRetrieverBuilderIT.java
Outdated
Show resolved
Hide resolved
pmpailis
approved these changes
Dec 12, 2025
Contributor
pmpailis
left a comment
pmpailis
left a comment
There was a problem hiding this comment.
Really nice! thanks @john-wagster 🚀
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
john-wagster
added a commit
to john-wagster/elasticsearch
that referenced
this pull request
Dec 13, 2025
* passing back message and status code from each failed shard instead
This was referenced Dec 13, 2025
john-wagster
added a commit
to john-wagster/elasticsearch
that referenced
this pull request
Dec 13, 2025
* passing back message and status code from each failed shard instead
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 13, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 13, 2025
parkertimmins
pushed a commit
to parkertimmins/elasticsearch
that referenced
this pull request
Dec 17, 2025
* passing back message and status code from each failed shard instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
exploring options for improving error handling for CompoundRetrieverBuilder particularly in the case where a response of sub retriever is 2xx but some shard failed to retrieve data.
addresses: #136529