[ES|QL] Return ConstNullBlock in FromAggMetricDouble#136773
Merged
limotova merged 3 commits intoelastic:mainfrom Oct 21, 2025
Merged
[ES|QL] Return ConstNullBlock in FromAggMetricDouble#136773limotova merged 3 commits intoelastic:mainfrom
limotova merged 3 commits intoelastic:mainfrom
Conversation
If we receive a block that contains all null values in FromAggregateMetricDouble, we want to return a new ConstantNullBlock, in order to allow other functions down the line to operate on it down the line like a typical null block, rather than an AggregateMetricDouble
limotova
added
>bug
:StorageEngine/ES|QL
Collaborator
|
Hi @limotova, I've created a changelog YAML for you. |
dnhatn
approved these changes
Oct 20, 2025
Member
dnhatn
left a comment
dnhatn
left a comment
There was a problem hiding this comment.
The fix looks good - thanks, Larisa! I think you can reproduce the issue in DownsampleIT with some intervals without data points.
limotova
force-pushed
the
const-null-block-from-agg-metric
branch
from
de095cb to
4cb03c5
Compare
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
dnhatn
approved these changes
Oct 21, 2025
Member
dnhatn
left a comment
dnhatn
left a comment
There was a problem hiding this comment.
The test looks good. Thanks Larisa!
limotova
added
auto-backport
Collaborator
💚 Backport successful
|
limotova
added a commit
to limotova/elasticsearch
that referenced
this pull request
Oct 21, 2025
If we receive a block that contains all null values in FromAggregateMetricDouble, we want to return a new ConstantNullBlock, in order to allow other functions down the line to operate on it down the line like a typical null block, rather than an AggregateMetricDouble
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 21, 2025
If we receive a block that contains all null values in FromAggregateMetricDouble, we want to return a new ConstantNullBlock, in order to allow other functions down the line to operate on it down the line like a typical null block, rather than an AggregateMetricDouble
fzowl
pushed a commit
to voyage-ai/elasticsearch
that referenced
this pull request
Nov 3, 2025
If we receive a block that contains all null values in FromAggregateMetricDouble, we want to return a new ConstantNullBlock, in order to allow other functions down the line to operate on it down the line like a typical null block, rather than an AggregateMetricDouble
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we receive a block that contains all null values in FromAggregateMetricDouble, we want to return a new ConstantNullBlock, in order to allow other functions down the line to operate on it like a typical null block, rather than an AggregateMetricDouble.