[ML] Update the voyageai integration#136782
Conversation
fzowl
commented
Oct 19, 2025
fzowl
commented
- correcting the multimodal integration
- adding the contextual model support
- refactoring
|
@fzowl please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation. |
elasticsearchmachine
added
v9.3.0
external-contributor
|
@davidkyle Can you please take a look? |
szybia
added
:ml
|
Pinging @elastic/ml-core (Team:ML) |
|
@elasticmachine test this please |
davidkyle
left a comment
davidkyle
left a comment
There was a problem hiding this comment.
@fzowl there has been a refactoring since the original PR #122134. All the VoyageAI related request and response classes have been moved from the org.elasticsearch.xpack.inference.external package to org.elasticsearch.xpack.inference.services.voyageai. It looks like git has recreated all the old classes in org.elasticsearch.xpack.inference.external
Please can you try to apply the changes to the classes in org.elasticsearch.xpack.inference.services.voyageai. It may be easier to close this PR and open another with the last few commits from this PR applied - e778e36 and b7351e7?
Thanks
- embeddings works, tested - initial rerank code What's missing: - unit and integration tests - rerank request/response mapping and verification
- embeddings works, tested - rerank works, tested (https://www.elastic.co/search-labs/blog/elasticsearch-cohere-rerank) What's missing: - unit and integration tests
- embeddings works, tested - rerank works, tested (https://www.elastic.co/search-labs/blog/elasticsearch-cohere-rerank) What's missing: - unit and integration tests
Moving dimensions to ServiceSettings
* Fix irregular spaces * Update analysis-keyword-repeat-tokenfilter.md * Update search-suggesters.md * Update search-profile.md
- Add multimodal embeddings support with VoyageAIMultimodalEmbeddings* classes - Add contextual embeddings support with VoyageAIContextualEmbeddings* classes - Refactor text embeddings: move to embeddings/text subdirectory for better organization - Remove old embedding classes from embeddings root directory - Update action creators and visitors to handle new embedding types - Update imports in InferenceNamedWriteablesProvider - Add corresponding request/response entities for multimodal and contextual embeddings - Update unit tests for all new and modified components
- Move text embeddings test files to text/ subdirectory - Fix package declarations in test files - Update VoyageAIEmbeddingsResponseEntityTests to use correct API methods - Change .service() to .getService() and add .getConfigurations() - NOTE: Additional test import fixes needed for full compilation
- Update all VoyageAI test imports to use embeddings/text package - Fix VoyageAIMultimodalEmbeddingsTaskSettings constructor calls (add truncation param) - Fix VoyageAIMultimodalEmbeddingsServiceSettings constructor calls (add embeddingType param) - Update test files: VoyageAIServiceTests, VoyageAIActionCreatorTests, VoyageAIEmbeddingsActionTests - Update test files: VoyageAIEmbeddingsRequestTests, VoyageAIRequestTests - Update test files: VoyageAIMultimodalEmbeddingsTaskSettingsTests, VoyageAIMultimodalEmbeddingsModelTests - Update test files: VoyageAIMultimodalEmbeddingsRequestTests Remaining: 3 compilation errors to fix
- Fix VoyageAIMultimodalEmbeddingsModel constructor call in response tests - Fix VoyageAIServiceTests multimodal model creation (add taskSettings param) - Fix VoyageAIContextualEmbeddingsTaskSettings ambiguous constructor - Cast SecretSettings to DefaultSecretSettings where required
fzowl
force-pushed
the
update_the_voyageai_integration
branch
from
cbdf827 to
17e88d6
Compare
|
Closing this PR as we've cleaned up the integration in the voyageai-integration-v2 branch. Opening a new PR with the clean changes. |
1 similar comment
|
Closing this PR as we've cleaned up the integration in the voyageai-integration-v2 branch. Opening a new PR with the clean changes. |
5 participants
