SQL: do not attempt to canonicalize InnerAggregate#136854
Merged
luigidellaquila merged 2 commits intoelastic:mainfrom Oct 21, 2025
Merged
SQL: do not attempt to canonicalize InnerAggregate#136854luigidellaquila merged 2 commits intoelastic:mainfrom
luigidellaquila merged 2 commits intoelastic:mainfrom
Conversation
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Collaborator
|
Hi @luigidellaquila, I've created a changelog YAML for you. |
bpintea
approved these changes
Oct 21, 2025
Contributor
bpintea
left a comment
There was a problem hiding this comment.
LGTM.
I think SELECT NULLIF(PERCENTILE(0+salary+salary, 50), 0) FROM test_emp should do for a test.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 22, 2025
Follow-up to #136854, just adding a test
fzowl
pushed a commit
to voyage-ai/elasticsearch
that referenced
this pull request
Nov 3, 2025
fzowl
pushed a commit
to voyage-ai/elasticsearch
that referenced
this pull request
Nov 3, 2025
Follow-up to elastic#136854, just adding a test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InnerAggregatedoes not supportreplaceChildren(), so we should not try to canonicalize it either.It's a very corner case, but it could happen (ref. ES-12727)
Unfortunately I don't have a reproducer (@bpintea probably you know this better than me, if you have ideas about this, I'll be happy to add a query to the tests)