ESQL: replace ExponentialHistogramBlock accessor with scratch#137368
Merged
JonasKunz merged 3 commits intoelastic:mainfrom Oct 30, 2025
Merged
ESQL: replace ExponentialHistogramBlock accessor with scratch#137368JonasKunz merged 3 commits intoelastic:mainfrom
JonasKunz merged 3 commits intoelastic:mainfrom
Conversation
elasticsearchmachine
added
needs:triage
JonasKunz
added
>non-issue
:Analytics/ES|QL
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
chrisparrinello
pushed a commit
to chrisparrinello/elasticsearch
that referenced
this pull request
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the iterator-like accessor for
ExponentialHistogramBlockwith the same pattern we already use forBytesRefBlock: The user has to allocate the memory for the return value and provide as an argument.We use a
ExponentialHistogramScratchclass to encapsulate the actual memory and block layout.This change makes the
ExponentialHistogramBlock(a) more consistent with the existing blocks and subsequently (b) makes it simpler to adapt our function code generation to work nicely with exponential histograms.