Skip to content

[9.1] Error if installed plugin is inside plugins folder (#137398)#137507

Merged
mamazzol merged 1 commit intoelastic:9.1from
mamazzol:backport/9.1/pr-137398
Nov 4, 2025
Merged

[9.1] Error if installed plugin is inside plugins folder (#137398)#137507
mamazzol merged 1 commit intoelastic:9.1from
mamazzol:backport/9.1/pr-137398

Conversation

@mamazzol
Copy link
Contributor

@mamazzol mamazzol commented Nov 3, 2025

Backport

This will backport the following commits from main to 9.1:

Questions ?

Please refer to the Backport tool documentation
@mamazzol
Error if installed plugin is inside plugins folder (elastic#137398)
63d1205 
* Error if installed plugin is inside plugins folder

If a non directory file is in the plugins folder during installation,
there will be a non descriptive error during findBundle, as it assumes
everything is a directory. This new preemptive check adds a descripive
error message to avoid this scenario.

Also, for consistency and to not use a deprecated URL constructor, in
the download method we now use URI.

Closes elastic#27401

(cherry picked from commit 941f302)
@mamazzol mamazzol requested a review from a team as a code owner November 3, 2025 09:42
@mamazzol mamazzol mentioned this pull request Nov 3, 2025
Merged
@ldematte ldematte added the :Core/Infra/Plugins Plugin API and infrastructure label Nov 4, 2025
ldematte
ldematte approved these changes Nov 4, 2025
View reviewed changes
Copy link
Contributor

@ldematte ldematte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@mamazzol mamazzol merged commit dc93b4d into elastic:9.1 Nov 4, 2025
35 checks passed
@mamazzol mamazzol deleted the backport/9.1/pr-137398 branch November 4, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport :Core/Infra/Plugins Plugin API and infrastructure v9.1.7

3 participants

@mamazzol @ldematte @elasticsearchmachine