Closed
Conversation
Contributor
leontyevdv
commented
Nov 5, 2025
leontyevdv
commented
- Add an ability to present the TSID_DATA_TYPE as KEYWORD.
- Add tests for the TopN optimization with METADATA _tsid.
- Add an ability to present the TSID_DATA_TYPE as KEYWORD. - Add tests for the TopN optimization with METADATA _tsid
leontyevdv
added
:StorageEngine/TSDB
dnhatn
reviewed
Nov 6, 2025
| val = BytesRef.deepCopyOf(scratch); | ||
| } | ||
|
|
||
| if (columnInfo.name().equalsIgnoreCase(MetadataAttribute.TSID_FIELD)) { |
Member
There was a problem hiding this comment.
I don't think we should add this workaround. We already have the _tsid type. Can you change the encoder for tsid to TopNEncoder.DEFAULT_UNSORTABLE cases in LocalExecutionPlanner#planTopN?
Contributor
Author
|
I'm closing this draft because I moved changes into another one to make a branch name meaningful. See #137706 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.