Reject mappings that (eventually) set dimension and metric in the same field

[gmarouli]

In this PR we add a check that will reject the following mapping:

PUT my-index-2
{
  "mappings": {
    "properties": {
      "attributes": {
          "type": "passthrough",
          "time_series_dimension": true,
          "priority": 20,
          "properties": {
            "attributes.kube_job_status_active": {
              "type": "double",
              "time_series_metric": "gauge"
            }
          }
      }
    }
  }
}

This mapping was rejected when assertions were enabled, but on production environments it was not checked properly.

The problem is that we were checking that a field cannot be both a dimension and a metric during parsing. When the mapping is first parsed the attributes.kube_job_status_active does not explicitly list "time_series_dimension": true so it passes the check, then during building the mappers we do add it but we do not recheck it then.

Now we check this when we build a NumberFieldMapper.

Fixes: #138044

[elasticsearchmachine]

Pinging @elastic/es-storage-engine (Team:StorageEngine)

[elasticsearchmachine]

Hi @gmarouli, I've created a changelog YAML for you.

[kkrik-es]

Nice, that was quick.

[elasticsearchmachine]

💚 Backport successful

Status	Branch	Result
✅	9.2
✅	8.19
✅	9.1