Change DatabaseNodeService error logs to warnings#138438
Merged
masseyke merged 3 commits intoelastic:mainfrom Nov 24, 2025
Merged
Change DatabaseNodeService error logs to warnings#138438masseyke merged 3 commits intoelastic:mainfrom
masseyke merged 3 commits intoelastic:mainfrom
Conversation
masseyke
added
>bug
:Distributed/Ingest Node
elasticsearchmachine
added
the
Team:Data Management (obsolete)
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
Collaborator
|
Hi @masseyke, I've created a changelog YAML for you. |
szybia
approved these changes
Nov 22, 2025
| @@ -0,0 +1,5 @@ | |||
| pr: 138438 | |||
Contributor
There was a problem hiding this comment.
should we backport as well?
sounds like a nice-to-have
masseyke
added
auto-backport
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
masseyke
added a commit
to masseyke/elasticsearch
that referenced
this pull request
Nov 24, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 24, 2025
afoucret
pushed a commit
to afoucret/elasticsearch
that referenced
this pull request
Nov 26, 2025
ncordon
pushed a commit
to ncordon/elasticsearch
that referenced
this pull request
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we have a problem retrieving a database, we log it at error level. However, this creates a lot of noise in the logs for little value -- the problem is almost guaranteed to be in a place this class cannot control. For example, we see this class log dozens of error-level log messages when the
.geoip_databasesshards cannot be allocated. But that is a more serious problem that is correctly logged elsewhere. This PR reduces the level of the logs to warn so that the presense of dozens error-level logs does not distract someone who is looking for the real problem.