Skip to content

Handle serialization of null blocks in AggregateMetricDoubleBlock#138539

Merged
dnhatn merged 4 commits intoelastic:mainfrom
dnhatn:fix-aggregate-metric-seri
Nov 24, 2025
Merged

Handle serialization of null blocks in AggregateMetricDoubleBlock#138539
dnhatn merged 4 commits intoelastic:mainfrom
dnhatn:fix-aggregate-metric-seri

Conversation

@dnhatn
Copy link
Member

@dnhatn dnhatn commented Nov 24, 2025

If a sub-block of an aggregate_metric_double block is a ConstantNullBlock, serialization fails because DoubleBlock.readFrom or IntBlock.readFrom are not compatible with ConstantNullBlock.writeTo.

@dnhatn dnhatn added >bug :StorageEngine/ES|QL Timeseries / metrics / PromQL / logsdb capabilities in ES|QL v9.3.0 v9.2.2 labels Nov 24, 2025
@elasticsearchmachine
Copy link
Collaborator

Hi @dnhatn, I've created a changelog YAML for you.

@dnhatn dnhatn added the auto-backport Automatically create backport pull requests when merged label Nov 24, 2025
@dnhatn dnhatn requested a review from limotova November 24, 2025 20:04
@dnhatn dnhatn marked this pull request as ready for review November 24, 2025 20:04
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@dnhatn
Copy link
Member Author

dnhatn commented Nov 24, 2025

Thanks Nik!

@dnhatn dnhatn merged commit 68ccba3 into elastic:main Nov 24, 2025
34 checks passed
@dnhatn dnhatn deleted the fix-aggregate-metric-seri branch November 24, 2025 23:46
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

The backport operation could not be completed due to the following error:

An unhandled error occurred. Please consult the logs

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 138539

dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Nov 25, 2025
…astic#138539)

If a sub-block of an aggregate_metric_double block is a
ConstantNullBlock, serialization fails because DoubleBlock.readFrom or
IntBlock.readFrom are not compatible with ConstantNullBlock.writeTo.
dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Nov 25, 2025
…astic#138539)

If a sub-block of an aggregate_metric_double block is a
ConstantNullBlock, serialization fails because DoubleBlock.readFrom or
IntBlock.readFrom are not compatible with ConstantNullBlock.writeTo.
dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Nov 25, 2025
…astic#138539)

If a sub-block of an aggregate_metric_double block is a
ConstantNullBlock, serialization fails because DoubleBlock.readFrom or
IntBlock.readFrom are not compatible with ConstantNullBlock.writeTo.
dnhatn added a commit that referenced this pull request Nov 26, 2025
…38539) (#138615)

Backport of #138539 to 9.2

If a sub-block of an aggregate_metric_double block is a
ConstantNullBlock, serialization fails because DoubleBlock.readFrom or
IntBlock.readFrom are not compatible with ConstantNullBlock.writeTo.

Relates #126653
Closes #135863
afoucret pushed a commit to afoucret/elasticsearch that referenced this pull request Nov 26, 2025
…astic#138539)

If a sub-block of an aggregate_metric_double block is a 
ConstantNullBlock, serialization fails because DoubleBlock.readFrom or
IntBlock.readFrom are not compatible with ConstantNullBlock.writeTo.
ncordon pushed a commit to ncordon/elasticsearch that referenced this pull request Nov 26, 2025
…astic#138539)

If a sub-block of an aggregate_metric_double block is a 
ConstantNullBlock, serialization fails because DoubleBlock.readFrom or
IntBlock.readFrom are not compatible with ConstantNullBlock.writeTo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged >bug :StorageEngine/ES|QL Timeseries / metrics / PromQL / logsdb capabilities in ES|QL Team:StorageEngine v9.2.2 v9.3.0

3 participants