Remove DOC_VALUES_SKIPPER feature flag#138723
Merged
romseygeek merged 36 commits intoelastic:mainfrom Dec 12, 2025
Merged
Conversation
This applies to boolean, date, ip, keyword and number-type fields excluding scaled_float. It can be disabled by setting the `index.mapping.use_doc_value_skipper` field to `false`
…pperTestCase.java Co-authored-by: Felix Barnsteiner <felixbarny@users.noreply.github.com>
…-false' into skippers/always-on-for-index-false
Removing this flag will enable skippers automatically on keyword, ip, boolean, date and numeric fields that have index=false. In addition, some fields in time_series and logsdb modes will default to using doc values skippers in place of points or terms indexes.
This reverts commit 1e8fcef.
elasticsearchmachine
added
needs:triage
romseygeek
added
>feature
release highlight
:StorageEngine/Mapping
romseygeek
requested review from
kkrik-es and
martijnvg
and removed request for
a team
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
felixbarny
reviewed
Nov 28, 2025
…' into skippers/remove-feature-flag
Contributor
Author
|
I've added an IndexVersion for serverless, with changes to MapperTestCase. |
felixbarny
reviewed
Dec 1, 2025
| assertThat(mapperService.fieldType("field").indexType(), equalTo(IndexType.docValuesOnly())); | ||
| } | ||
|
|
||
| Settings statelessSkipperDefault = Settings.builder().put(DiscoveryNode.STATELESS_ENABLED_SETTING_NAME, true).build(); |
Member
There was a problem hiding this comment.
Suggested change
| Settings statelessSkipperDefault = Settings.builder().put(DiscoveryNode.STATELESS_ENABLED_SETTING_NAME, true).build(); | |
| Settings statelessEnabled = Settings.builder().put(DiscoveryNode.STATELESS_ENABLED_SETTING_NAME, true).build(); |
server/src/main/java/org/elasticsearch/index/IndexSettings.java
Outdated
Show resolved
Hide resolved
…' into skippers/remove-feature-flag
martijnvg
reviewed
Dec 8, 2025
| IndexVersion iv = SETTING_INDEX_VERSION_CREATED.get(s); | ||
| if (MODE.get(s) == IndexMode.TIME_SERIES) { | ||
| if (iv.onOrAfter(IndexVersions.SKIPPERS_ENABLED_BY_DEFAULT)) { | ||
| if (DiscoveryNode.isStateless(s)) { |
Member
There was a problem hiding this comment.
Maybe I forgot something, but host.name was the only field we accidentally enabled skippers for? This would enable skippers also for other fields in serverless?
Contributor
Author
There was a problem hiding this comment.
This part is for TSDB mode. host.name is handled entirely separately.
…' into skippers/remove-feature-flag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing this flag will enable skippers automatically on keyword, ip, boolean,
date and numeric fields that have index=false and doc_values=true when the
index.mapping.use_doc_values_skippersetting istrue. In addition,some fields in time_series mode will default to using doc values skippers in place
of points or terms indexes.