Add node scoped vectors.indexing.use_gpu setting by mayya-sharipova · Pull Request #138738 · elastic/elasticsearch

mayya-sharipova · 2025-11-27T19:17:24Z

Replace per-index GPU setting with a static node-scoped
vectors.indexing.use_gpu setting supporting true/false/auto modes
(default: auto).

Node will fail to start if GPU vector indexing is required (true), but unavailable.
GPU will be used for indexing on supported types if setting is true or auto and GPU is available.

Replace per-index GPU setting with a static node-scoped vectors.indexing.use_gpu setting supporting true/false/auto modes (default: auto). Node will fail to start if GPU vector indexing is required but unavailable.

elasticsearchmachine · 2025-11-27T19:17:50Z

Pinging @elastic/es-search-relevance (Team:Search Relevance)

elasticsearchmachine · 2025-11-27T19:17:50Z

Hi @mayya-sharipova, I've created a changelog YAML for you.

x-pack/plugin/gpu/src/main/java/org/elasticsearch/xpack/gpu/GPUPlugin.java

x-pack/plugin/gpu/src/internalClusterTest/java/org/elasticsearch/xpack/gpu/GPUIndexIT.java

ChrisHegarty

LGTM

ldematte

Looks good, thanks! Left some questions, mainly about testing.

ldematte · 2025-12-01T16:14:07Z

x-pack/plugin/gpu/src/internalClusterTest/java/org/elasticsearch/xpack/gpu/GPUIndexIT.java

        }
    }

-    public void testSearchWithoutGPU() {


Don't we want/need to replace this test? (search on the CPU works when GPU disabled?)

Yes, good point.
this test is good to have but may be not in GPUIndexIT, as the cluster in this test is started with GpuMode.TRUE.name.

I will follow up with another PR to add this test in a separate module.

In alternative, it maybe can be a different YAML test (see below). OK to add it as a follow-up.

...nternalClusterTest/java/org/elasticsearch/xpack/gpu/GPUPluginInitializationWithoutGPUIT.java

x-pack/plugin/gpu/src/main/java/org/elasticsearch/xpack/gpu/GPUPlugin.java

ldematte · 2025-12-01T16:22:12Z

x-pack/plugin/gpu/src/main/java/org/elasticsearch/xpack/gpu/GPUPlugin.java

+            Settings settings = context.settings();
+            GpuMode gpuMode = VECTORS_INDEXING_USE_GPU_NODE_SETTING.get(settings);
+
+            if (gpuMode == GpuMode.TRUE && GPUSupport.isSupported() == false) {


Do we want to check license here too? (isGpuIndexingFeatureAllowed()?)

I thought about this, but decided against it for these reasons:

Looks like Boostrap check is designed for infrastructure check, not business logic. I checked all other its implementers and all they only do infrastructure-focused checks (JVM heap, memory, file size etc)

License are mutable and updatable through API. Thus we should not fail to start a node without license, because a license can be later updated through an API to enable the GPu feature.

WDYT, @ldematte ?

I'm a bit torn; your points are very good, but I wonder if it's a better user experience if we tell the user right away if they want to use the GPU and don't have a valid license. True, the license can be updated afterwards, but this would be a first check that everything (or most things) are in the right place.

Since I'm not 100% sure what's best, we can leave it this way.

I will raise this for our sync discussion.

ldematte · 2025-12-01T16:23:56Z

...k/plugin/gpu/src/yamlRestTest/java/org/elasticsearch/xpack/gpu/GPUClientYamlTestSuiteIT.java

            .module("gpu")
            .setting("xpack.license.self_generated.type", "trial")
            .setting("xpack.security.enabled", "false")
+            .setting("vectors.indexing.use_gpu", "true")


Do we want/need tests for false too?

I am interested to know why you think we need to test for false?
For false we default to CPU and we already have a lot of yml tests outside of GPU plugin for testing how hsnw and int8_hnws work on CPU.

I was thinking about the test above, "(search on the CPU works when GPU disabled)". Instead of a IT test, it could be a YAML test. (Either one or the other, no need to have both).
It's OK to add either in a follow-up though.

I will add the follow up.

ldematte

👍

elasticsearchmachine · 2025-12-02T11:49:33Z

💚 Backport successful

Status	Branch	Result
✅	9.2

Replace per-index GPU setting with a static node-scoped vectors.indexing.use_gpu setting supporting true/false/auto modes (default: auto). Node will fail to start if GPU vector indexing is required but unavailable.

Add node-scoped vectors.indexing.use_gpu setting

0ebf5e5

Replace per-index GPU setting with a static node-scoped vectors.indexing.use_gpu setting supporting true/false/auto modes (default: auto). Node will fail to start if GPU vector indexing is required but unavailable.

mayya-sharipova requested review from ChrisHegarty and ldematte November 27, 2025 19:17

mayya-sharipova added >enhancement :Search Relevance/Vectors Vector search v9.3.0 v9.2.3 labels Nov 27, 2025

elasticsearchmachine added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Nov 27, 2025

Update docs/changelog/138738.yaml

a7d96ca

mayya-sharipova added the test-gpu Run tests using a GPU label Nov 27, 2025

mayya-sharipova commented Nov 27, 2025

View reviewed changes

x-pack/plugin/gpu/src/main/java/org/elasticsearch/xpack/gpu/GPUPlugin.java Outdated Show resolved Hide resolved

ChrisHegarty reviewed Nov 28, 2025

View reviewed changes

x-pack/plugin/gpu/src/internalClusterTest/java/org/elasticsearch/xpack/gpu/GPUIndexIT.java Outdated Show resolved Hide resolved

Remove Inject

e24e33d

ChrisHegarty approved these changes Dec 1, 2025

View reviewed changes

mayya-sharipova removed the test-gpu Run tests using a GPU label Dec 1, 2025

Merge branch 'main' into gpu_node_setting

ba6af8c

mayya-sharipova added auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) labels Dec 1, 2025

mayya-sharipova added 4 commits December 1, 2025 09:31

Merge branch 'main' into gpu_node_setting

212f73c

Merge branch 'main' into gpu_node_setting

8d3faad

Merge branch 'main' into gpu_node_setting

661493d

Merge branch 'main' into gpu_node_setting

af89018

ldematte reviewed Dec 1, 2025

View reviewed changes

mayya-sharipova removed the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Dec 1, 2025

ldematte approved these changes Dec 2, 2025

View reviewed changes

mayya-sharipova merged commit 38de567 into elastic:main Dec 2, 2025
34 checks passed

mayya-sharipova deleted the gpu_node_setting branch December 2, 2025 11:48

mayya-sharipova mentioned this pull request Dec 2, 2025

[9.2] Add node scoped vectors.indexing.use_gpu setting (#138738) #138881

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add node scoped vectors.indexing.use_gpu setting#138738

Add node scoped vectors.indexing.use_gpu setting#138738
mayya-sharipova merged 8 commits intoelastic:mainfrom
mayya-sharipova:gpu_node_setting

mayya-sharipova commented Nov 27, 2025

elasticsearchmachine commented Nov 27, 2025

elasticsearchmachine commented Nov 27, 2025

Uh oh!

Uh oh!

ChrisHegarty left a comment

ldematte left a comment

ldematte Dec 1, 2025

mayya-sharipova Dec 1, 2025

ldematte Dec 2, 2025

Uh oh!

Uh oh!

ldematte Dec 1, 2025

mayya-sharipova Dec 1, 2025 •

edited

Loading

ldematte Dec 2, 2025

mayya-sharipova Dec 2, 2025 •

edited

Loading

ldematte Dec 1, 2025

mayya-sharipova Dec 1, 2025 •

edited

Loading

ldematte Dec 2, 2025

mayya-sharipova Dec 2, 2025

ldematte left a comment

Uh oh!

elasticsearchmachine commented Dec 2, 2025

Labels

4 participants

Conversation

mayya-sharipova commented Nov 27, 2025

elasticsearchmachine commented Nov 27, 2025

elasticsearchmachine commented Nov 27, 2025

Uh oh!

Uh oh!

ChrisHegarty left a comment

Choose a reason for hiding this comment

ldematte left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

mayya-sharipova Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mayya-sharipova Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mayya-sharipova Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ldematte left a comment

Choose a reason for hiding this comment

Uh oh!

elasticsearchmachine commented Dec 2, 2025

💚 Backport successful

Labels

4 participants

mayya-sharipova Dec 1, 2025 •

edited

Loading

mayya-sharipova Dec 2, 2025 •

edited

Loading

mayya-sharipova Dec 1, 2025 •

edited

Loading