Skip to content

Bump mustache.java to 0.9.14#138923

Merged
joegallo merged 12 commits intoelastic:mainfrom
joegallo:bump-mustache
Dec 3, 2025
Merged

Bump mustache.java to 0.9.14#138923
joegallo merged 12 commits intoelastic:mainfrom
joegallo:bump-mustache

Conversation

@joegallo
Copy link
Contributor

@joegallo joegallo commented Dec 2, 2025

I am looking at optimizing some of the hotter code paths within mustache template application, as this affects both document level security (DLS) and (less surprising) ingest processors. Since I'm in the area anyway, it seemed reasonable to make sure were running the most recent version of the mustache.java dependency.

@joegallo joegallo requested a review from masseyke December 2, 2025 17:34
@joegallo joegallo requested a review from a team as a code owner December 2, 2025 17:34
@joegallo joegallo requested a review from a team as a code owner December 2, 2025 17:34
@joegallo joegallo added :Distributed/Ingest Node Execution or management of Ingest Pipelines Team:Data Management (obsolete) DO NOT USE. This team no longer exists. v9.3.0 labels Dec 2, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine
Copy link
Collaborator

Hi @joegallo, I've created a changelog YAML for you.

@joegallo
Copy link
Contributor Author

joegallo commented Dec 2, 2025

joegallo@simulacron:~/Code/spullara/mustache.java $ git log --oneline 0.9.10..mustache.java-0.9.14 -- compiler/src/main
702606fc add support for dynamicnames
adb82eb6 Fix ClasspathResolver for non-context class loader case
a58f7a20 Make ClasspathResolver thread-safe
39dbf470 Remove unused imports from AbstractObjectHandler
304f71a0 ISSUE-291: fix substring issue with empty dot
c4c5a6f6 share find code between Map/Simple object handlers
283f9069 formatting
9b194469 added mapobjecthandler
22097736 add AbstractObjectHandler
a09a8992 Add option of disabling reflection in SimpleObjectHandler
bd12b615 Fix behaviour of nested IndentWriters
7fa780b3 Add FileSystemResolver(Path) constructor
63074672 undo import *
efb67c49 ISSUE-268: If the resulting template is a directory we should fail
a05a3ff3 ISSUE-266: add a character location for an improperly closed variable
@dakrone
Copy link
Member

dakrone commented Dec 2, 2025

I think we need to ensure that we disable dynamic names in our Mustache templating, since this is a new feature that we should not allow.

Copy link
Member

@masseyke masseyke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Lee's comment makes sense though.

@joegallo joegallo added :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache Team:Core/Infra Meta label for core/infra team labels Dec 2, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@joegallo

This comment was marked as outdated.

@joegallo joegallo marked this pull request as draft December 2, 2025 22:24
@joegallo

This comment was marked as resolved.

@joegallo

This comment was marked as resolved.

@joegallo joegallo marked this pull request as ready for review December 3, 2025 21:33
@joegallo joegallo requested a review from masseyke December 3, 2025 21:34
@joegallo
Copy link
Contributor Author

joegallo commented Dec 3, 2025

I think we need to ensure that we disable dynamic names in our Mustache templating, since this is a new feature that we should not allow.

++, I handled that in 91f18b5.

@joegallo joegallo merged commit 6ed2b27 into elastic:main Dec 3, 2025
34 checks passed
@joegallo joegallo deleted the bump-mustache branch December 3, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache :Distributed/Ingest Node Execution or management of Ingest Pipelines >enhancement Team:Core/Infra Meta label for core/infra team Team:Data Management (obsolete) DO NOT USE. This team no longer exists. v9.3.0

4 participants