Disk bbq license enforcement#139087
Merged
elasticsearchmachine merged 17 commits intoelastic:mainfrom Dec 8, 2025
Merged
Conversation
elasticsearchmachine
added
Team:Search Relevance
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
Collaborator
|
Hi @benwtrent, I've created a changelog YAML for you. |
…lasticsearch into disk-bbq-license-enforcement
| } | ||
|
|
||
| public void testCreateDiskBBQIndexRestricted() { | ||
| disableLicensing(randomInvalidLicenseType()); |
Contributor
There was a problem hiding this comment.
What does it mean disabling invalid license?
If the license type is already invalid, doesn't support DiskBBQ anyway, so why also mark it as inactive?
Member
Author
There was a problem hiding this comment.
good callout, let me adjust these tests. we should test with NO license and with a random invalid license.
| client().prepareSearch("diskbbq-index") | ||
| .setKnnSearch(List.of(new KnnSearchBuilder("vector", new float[] { 0.1f, 0.2f, 0.3f, 0.4f }, 10, 10, null, null, null))) | ||
| .get(); | ||
| // disable license and read, it should not throw on read |
Contributor
There was a problem hiding this comment.
Should there be license change here?
Member
Author
There was a problem hiding this comment.
yeah, I missed it, good call
Contributor
mayya-sharipova
left a comment
mayya-sharipova
left a comment
There was a problem hiding this comment.
Thanks Ben, LGTM!
mayya-sharipova
approved these changes
Dec 4, 2025
john-wagster
approved these changes
Dec 4, 2025
Contributor
john-wagster
left a comment
john-wagster
left a comment
There was a problem hiding this comment.
lgtm; this touched less than I thought it would. nice!
benwtrent
added
the
auto-merge-without-approval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enforces enterprise license for bbq_disk (DiskBBQ) indices.