Let terms queries rewrite to a filter on constant_keyword fields#139106
Merged
jimczi merged 8 commits intoelastic:mainfrom Dec 10, 2025
Merged
Let terms queries rewrite to a filter on constant_keyword fields#139106jimczi merged 8 commits intoelastic:mainfrom
jimczi merged 8 commits intoelastic:mainfrom
Conversation
This commit fixes the logic that lets a `terms` aggregation rewrite into a `filters` aggregation.
For `constant_keyword` fields, every doc has the same value, so we can just rewrite the whole thing into a single `match_all` filter instead of handling multiple terms.
```json
{
"aggs": {
"by_index": {
"terms": {
"field": "_index"
}
}
}
}
```
jimczi
added
>enhancement
:Analytics/Aggregations
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Collaborator
|
Hi @jimczi, I've created a changelog YAML for you. |
romseygeek
approved these changes
Dec 5, 2025
server/src/main/java/org/elasticsearch/index/fielddata/FieldDataContext.java
Outdated
Show resolved
Hide resolved
…taContext.java Co-authored-by: Alan Woodward <romseygeek@gmail.com>
jimczi
added
the
auto-backport
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes the logic that lets a
termsaggregation rewrite into afiltersaggregation. Forconstant_keywordfields, every doc has the same value, so we can just rewrite the whole thing into a singlematch_allfilter instead of handling multiple terms.{ "aggs": { "by_index": { "terms": { "field": "_index" } } } }