Fix offset maths bug in InetAddress parsing#139420
Merged
elasticsearchmachine merged 2 commits intoelastic:mainfrom Dec 12, 2025
Merged
Fix offset maths bug in InetAddress parsing#139420elasticsearchmachine merged 2 commits intoelastic:mainfrom
elasticsearchmachine merged 2 commits intoelastic:mainfrom
Conversation
InetAddress parsing can look at arbitrary sections of a byte array indexed by offset and length. We adjust the length to remove scope IDs, but were not taking into account the offset, so parsing operations that examined the end of a byte array could inadvertently try and read past the end.
romseygeek
added
>bug
:StorageEngine/Mapping
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Collaborator
|
Hi @romseygeek, I've created a changelog YAML for you. |
felixbarny
approved these changes
Dec 12, 2025
romseygeek
added
auto-merge-without-approval
salvatore-campagna
approved these changes
Dec 12, 2025
romseygeek
added a commit
to romseygeek/elasticsearch
that referenced
this pull request
Dec 12, 2025
InetAddress parsing can look at arbitrary sections of a byte array indexed by offset and length. We adjust the length to remove scope IDs, but were not taking into account the offset, so parsing operations that examined the end of a byte array could inadvertently try and read past the end.
Collaborator
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 12, 2025
InetAddress parsing can look at arbitrary sections of a byte array indexed by offset and length. We adjust the length to remove scope IDs, but were not taking into account the offset, so parsing operations that examined the end of a byte array could inadvertently try and read past the end.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InetAddress parsing can look at arbitrary sections of a byte array
indexed by offset and length. We adjust the length to remove scope
IDs, but were not taking into account the offset, so parsing operations
that examined the end of a byte array could inadvertently try and read
past the end.