Skip to content

Add bfloat16 support to rank_vectors#139463

Merged
thecoop merged 9 commits intoelastic:mainfrom
thecoop:rank-vectors-bfloat16
Dec 15, 2025
Merged

Add bfloat16 support to rank_vectors#139463
thecoop merged 9 commits intoelastic:mainfrom
thecoop:rank-vectors-bfloat16

Conversation

@thecoop
Copy link
Member

@thecoop thecoop commented Dec 12, 2025

Add BFloat16 implementations to complete rank_vectors support

@thecoop thecoop force-pushed the rank-vectors-bfloat16 branch from 01ea2ee to 679f188 Compare December 12, 2025 17:28
@thecoop thecoop marked this pull request as ready for review December 15, 2025 09:50
@elasticsearchmachine elasticsearchmachine added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Dec 15, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@elasticsearchmachine
Copy link
Collaborator

Hi @thecoop, I've created a changelog YAML for you.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2025

@github-actions
Copy link
Contributor

ℹ️ Important: Docs version tagging

👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version.

We use applies_to tags to mark version-specific features and changes.

Expand for a quick overview

When to use applies_to tags:

✅ At the page level to indicate which products/deployments the content applies to (mandatory)
✅ When features change state (e.g. preview, ga) in a specific version
✅ When availability differs across deployments and environments

What NOT to do:

❌ Don't remove or replace information that applies to an older version
❌ Don't add new information that applies to a specific version without an applies_to tag
❌ Don't forget that applies_to tags can be used at the page, section, and inline level

🤔 Need help?

@thecoop thecoop force-pushed the rank-vectors-bfloat16 branch from b992b24 to 73a97b3 Compare December 15, 2025 12:39
Copy link
Member

@benwtrent benwtrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor concern about yaml test versioning. But, this looks good.

Comment on lines 21 to 24
bfloat16_vector:
type: rank_vectors
dims: 5
element_type: bfloat16
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to guard this with a test feature?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like not - these tests arent run in BWC scenarios

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll create a separate PR to get the YAML in, so there's time to work out what's actually needed here

@thecoop thecoop added the test-full-bwc Trigger full BWC version matrix tests label Dec 15, 2025
@thecoop thecoop added test-release Trigger CI checks against release build and removed test-full-bwc Trigger full BWC version matrix tests labels Dec 15, 2025
Copy link
Contributor

@john-wagster john-wagster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thecoop thecoop removed the test-release Trigger CI checks against release build label Dec 15, 2025
@thecoop thecoop merged commit 06f6edf into elastic:main Dec 15, 2025
6 of 9 checks passed
@thecoop thecoop deleted the rank-vectors-bfloat16 branch December 15, 2025 19:34
parkertimmins pushed a commit to parkertimmins/elasticsearch that referenced this pull request Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>feature :Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.3.0

4 participants