Add bfloat16 support to rank_vectors#139463
Conversation
01ea2ee to
679f188
Compare
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
|
Hi @thecoop, I've created a changelog YAML for you. |
🔍 Preview links for changed docs |
ℹ️ Important: Docs version tagging👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version. We use applies_to tags to mark version-specific features and changes. Expand for a quick overviewWhen to use applies_to tags:✅ At the page level to indicate which products/deployments the content applies to (mandatory) What NOT to do:❌ Don't remove or replace information that applies to an older version 🤔 Need help?
|
b992b24 to
73a97b3
Compare
benwtrent
left a comment
There was a problem hiding this comment.
Minor concern about yaml test versioning. But, this looks good.
| bfloat16_vector: | ||
| type: rank_vectors | ||
| dims: 5 | ||
| element_type: bfloat16 |
There was a problem hiding this comment.
Don't we need to guard this with a test feature?
There was a problem hiding this comment.
It looks like not - these tests arent run in BWC scenarios
There was a problem hiding this comment.
I'll create a separate PR to get the YAML in, so there's time to work out what's actually needed here
Add BFloat16 implementations to complete
rank_vectorssupport