Skip to content

No EsqlIllegalArgumentException for invalid window values#139470

Merged
kkrik-es merged 3 commits intoelastic:mainfrom
kkrik-es:tsdb/fix-window-checks
Dec 12, 2025
Merged

No EsqlIllegalArgumentException for invalid window values#139470
kkrik-es merged 3 commits intoelastic:mainfrom
kkrik-es:tsdb/fix-window-checks

Conversation

@kkrik-es
Copy link
Contributor

EsqlIllegalArgumentException shouldn't be used to errors related to user-provided inputs as it leads to 500 errors. Instead, lIllegalArgumentException leads to 400s and is thus preferable.

@kkrik-es kkrik-es self-assigned this Dec 12, 2025
@kkrik-es kkrik-es added >bug Team:StorageEngine :StorageEngine/ES|QL Timeseries / metrics / PromQL / logsdb capabilities in ES|QL labels Dec 12, 2025
@elasticsearchmachine
Copy link
Collaborator

Hi @kkrik-es, I've created a changelog YAML for you.

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kkrik-es kkrik-es marked this pull request as ready for review December 12, 2025 20:38
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@kkrik-es kkrik-es merged commit b8283e3 into elastic:main Dec 12, 2025
36 checks passed
@kkrik-es kkrik-es deleted the tsdb/fix-window-checks branch December 13, 2025 15:57
parkertimmins pushed a commit to parkertimmins/elasticsearch that referenced this pull request Dec 17, 2025
…9470)

* No EsqlIllegalArgumentException for invalid window values

* Update docs/changelog/139470.yaml

* [CI] Auto commit changes from spotless

---------

Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>bug :StorageEngine/ES|QL Timeseries / metrics / PromQL / logsdb capabilities in ES|QL Team:StorageEngine v9.3.0

3 participants