Skip to content

Fix index.mapping.use_doc_values_skipper defaults in serverless#139532

Merged
jordan-powers merged 5 commits intoelastic:patch/serverless-fixfrom
romseygeek:patch/serverless-fix
Dec 15, 2025
Merged

Fix index.mapping.use_doc_values_skipper defaults in serverless#139532
jordan-powers merged 5 commits intoelastic:patch/serverless-fixfrom
romseygeek:patch/serverless-fix

Conversation

@romseygeek
Copy link
Contributor

We can't detect whether or not we are in serverless during default value
setup because we don't have node settings at this point. This removes
all serverless/stateful detection logic from here, as the various different
index structure changes made during development were never released
and we can use some much simpler checks.

romseygeek and others added 3 commits December 15, 2025 14:44
We can't detect whether or not we are in serverless during default
value setup because we don't have node settings at this point.  This
removes all serverless/stateful detection logic from here, as the
various different index structure changes made during development
were never released and we can use some much simpler checks.
@romseygeek romseygeek self-assigned this Dec 15, 2025
@romseygeek romseygeek requested a review from ldematte December 15, 2025 14:46
@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label Dec 15, 2025
@romseygeek romseygeek added >bug :StorageEngine/Mapping The storage related side of mappings v9.3.0 and removed needs:triage Requires assignment of a team area label labels Dec 15, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

1 similar comment
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@romseygeek romseygeek requested a review from martijnvg December 15, 2025 16:38
@elasticsearchmachine elasticsearchmachine added the serverless-linked Added by automation, don't add manually label Dec 15, 2025
Copy link
Contributor

@jordan-powers jordan-powers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jordan-powers
Copy link
Contributor

Note: this is a duplicate of #139526, but bringing the changes into patch/serverless-fix.

@jordan-powers jordan-powers enabled auto-merge (squash) December 15, 2025 17:13
@jordan-powers jordan-powers merged commit 53fe0ea into elastic:patch/serverless-fix Dec 15, 2025
35 checks passed
jordan-powers added a commit that referenced this pull request Dec 18, 2025
jordan-powers added a commit to jordan-powers/elasticsearch that referenced this pull request Dec 18, 2025
elasticsearchmachine pushed a commit that referenced this pull request Dec 18, 2025
szybia added a commit to szybia/elasticsearch that referenced this pull request Jan 7, 2026
* upstream/main:
  Add hook for blocking termination (elastic#133555)
  Delegate to ES93ScalarQuantizedVectorsFormat rather than copying behaviour (elastic#139834)
  Refactor compound block types (elastic#140219)
  Flush the rate buffer when the slice index changes (elastic#138856)
  Log linked project connection errors at debug during shutdown (elastic#140239)
  Periodic FIPS 140-3 buildkite pipelines (elastic#139909)
  ES|QL - Remove TERM function (elastic#139953)
  Fix name of started time field in shutdown status (elastic#139910)
  Drop `project_routing` from query params (elastic#140272)
  Fix flaky test: AllocationDecidersTests (elastic#140271)
  Add List Reindex API (elastic#140184)
  Expose _tier metadata attribute in ESQL (elastic#139894)
  Tweak TSDBRestEsqlIT#testTimeSeriesQuerying(...) (elastic#140210)
  Fix an OOM error when creating to many chained synonym graph token filter. (elastic#140026)
  Suppress Azure SDK error logs (elastic#139730)
  Rewritten integer sorts need to use SortedNumericSortField (elastic#139538) (elastic#139700)
  Adjust index versions for skippers for time series (elastic#139670)
  Fix host.name skippers index version range (elastic#139636)
  Remove BWC shim for a broken commit
  Fix index.mapping.use_doc_values_skipper defaults in serverless (elastic#139532)
sidosera pushed a commit to sidosera/elasticsearch that referenced this pull request Jan 7, 2026
…tic#139532)

We can't detect whether or not we are in serverless during default
value setup because we don't have node settings at this point.  This
removes all serverless/stateful detection logic from here, as the
various different index structure changes made during development
were never released and we can use some much simpler checks.

# Conflicts:
#	server/src/main/java/org/elasticsearch/index/IndexSettings.java
sidosera pushed a commit to sidosera/elasticsearch that referenced this pull request Jan 7, 2026
…tic#139532)

We can't detect whether or not we are in serverless during default
value setup because we don't have node settings at this point.  This
removes all serverless/stateful detection logic from here, as the
various different index structure changes made during development
were never released and we can use some much simpler checks.

# Conflicts:
#	server/src/main/java/org/elasticsearch/index/IndexSettings.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>bug serverless-linked Added by automation, don't add manually :StorageEngine/Mapping The storage related side of mappings Team:StorageEngine v9.3.0

3 participants