ES|QL: Fix ABSENT/PRESENT on agg with false filter#139609
Merged
dimitris-athanasiou merged 3 commits intoelastic:mainfrom Dec 16, 2025
Merged
Conversation
This query ``` ROW a = 42 | STATS ABSENT(a) WHERE FALSE ``` currently returns `null`. However, it should return `true` for `ABSENT`, or `false` for `PRESENT`. This fixes this bug. The problem is that we have a rule for replacing aggs with false filter with an eval: `ReplaceStatsFilteredAggWithEval`. That rule needs to be updated to handle `ABSENT/PRESENT` in order to provide the correct value for those functions instead of `null`. Relates elastic#131069
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Collaborator
|
Hi @dimitris-athanasiou, I've created a changelog YAML for you. |
leontyevdv
approved these changes
Dec 16, 2025
Contributor
leontyevdv
left a comment
leontyevdv
left a comment
There was a problem hiding this comment.
LGTM. Thanks for fixing this @dimitris-athanasiou!
dimitris-athanasiou
added
the
auto-backport
Collaborator
💔 Backport failedYou can use sqren/backport to manually backport by running |
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
dimitris-athanasiou
added a commit
to dimitris-athanasiou/elasticsearch
that referenced
this pull request
Dec 18, 2025
This query ``` ROW a = 42 | STATS ABSENT(a) WHERE FALSE ``` currently returns `null`. However, it should return `true` for `ABSENT`, or `false` for `PRESENT`. This fixes this bug. The problem is that we have a rule for replacing aggs with false filter with an eval: `ReplaceStatsFilteredAggWithEval`. That rule needs to be updated to handle `ABSENT/PRESENT` in order to provide the correct value for those functions instead of `null`. Relates elastic#131069 (cherry picked from commit c77fb96) # Conflicts: # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/action/EsqlCapabilities.java
dimitris-athanasiou
added a commit
that referenced
this pull request
Dec 18, 2025
This query ``` ROW a = 42 | STATS ABSENT(a) WHERE FALSE ``` currently returns `null`. However, it should return `true` for `ABSENT`, or `false` for `PRESENT`. This fixes this bug. The problem is that we have a rule for replacing aggs with false filter with an eval: `ReplaceStatsFilteredAggWithEval`. That rule needs to be updated to handle `ABSENT/PRESENT` in order to provide the correct value for those functions instead of `null`. Relates #131069 (cherry picked from commit c77fb96)
dimitris-athanasiou
deleted the
fix-esql-present/absent-on-stats-with-false-filter
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This query
currently returns
null.However, it should return
trueforABSENT, orfalseforPRESENT.This fixes this bug. The problem is that we have a rule for replacing aggs with false filter with an eval:
ReplaceStatsFilteredAggWithEval. That rule needs to be updated to handleABSENT/PRESENTin order to provide the correct value for those functions instead ofnull.Relates #131069