Skip to content

Making sure that failure store document converter does not hang on unexpected exceptions#139712

Merged
elasticsearchmachine merged 3 commits intoelastic:mainfrom
masseyke:fix/failure-store-doc-converter-hangs
Dec 17, 2025
Merged

Making sure that failure store document converter does not hang on unexpected exceptions#139712
elasticsearchmachine merged 3 commits intoelastic:mainfrom
masseyke:fix/failure-store-doc-converter-hangs

Conversation

@masseyke
Copy link
Member

This makes sure that bulk requests do not hang if the FailureStoreDocumentConverter fails for a reason we are not expecting.
Closes #139707

@masseyke masseyke added :StorageEngine/Data streams Data streams and their lifecycles auto-backport Automatically create backport pull requests when merged v9.3.0 v9.1.10 v9.2.4 v8.19.10 labels Dec 17, 2025
@masseyke masseyke requested a review from jbaiera December 17, 2025 19:51
@elasticsearchmachine elasticsearchmachine added Team:Data Management (obsolete) DO NOT USE. This team no longer exists. v9.4.0 labels Dec 17, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

Copy link
Member

@jbaiera jbaiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@masseyke masseyke added the >bug label Dec 17, 2025
@elasticsearchmachine
Copy link
Collaborator

Hi @masseyke, I've created a changelog YAML for you.

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this Keith!

@masseyke masseyke added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Dec 17, 2025
@elasticsearchmachine elasticsearchmachine merged commit d3e0128 into elastic:main Dec 17, 2025
35 checks passed
@masseyke masseyke deleted the fix/failure-store-doc-converter-hangs branch December 17, 2025 23:29
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
9.1
9.2
8.19
masseyke added a commit to masseyke/elasticsearch that referenced this pull request Dec 17, 2025
…expected exceptions (elastic#139712)

This makes sure that bulk requests do not hang if the
FailureStoreDocumentConverter fails for a reason we are not expecting.
Closes elastic#139707
masseyke added a commit to masseyke/elasticsearch that referenced this pull request Dec 17, 2025
…expected exceptions (elastic#139712)

This makes sure that bulk requests do not hang if the
FailureStoreDocumentConverter fails for a reason we are not expecting.
Closes elastic#139707
masseyke added a commit to masseyke/elasticsearch that referenced this pull request Dec 17, 2025
…expected exceptions (elastic#139712)

This makes sure that bulk requests do not hang if the
FailureStoreDocumentConverter fails for a reason we are not expecting.
Closes elastic#139707
elasticsearchmachine pushed a commit that referenced this pull request Dec 18, 2025
…expected exceptions (#139712) (#139720)

This makes sure that bulk requests do not hang if the
FailureStoreDocumentConverter fails for a reason we are not expecting.
Closes #139707
elasticsearchmachine pushed a commit that referenced this pull request Dec 18, 2025
…expected exceptions (#139712) (#139718)

This makes sure that bulk requests do not hang if the
FailureStoreDocumentConverter fails for a reason we are not expecting.
Closes #139707
elasticsearchmachine pushed a commit that referenced this pull request Dec 18, 2025
…expected exceptions (#139712) (#139719)

This makes sure that bulk requests do not hang if the
FailureStoreDocumentConverter fails for a reason we are not expecting.
Closes #139707
@masseyke masseyke added the v9.3.1 label Jan 7, 2026
@masseyke
Copy link
Member Author

masseyke commented Jan 7, 2026

💚 All backports created successfully

Status Branch Result
9.3

Questions ?

Please refer to the Backport tool documentation

masseyke added a commit to masseyke/elasticsearch that referenced this pull request Jan 7, 2026
…expected exceptions (elastic#139712)

This makes sure that bulk requests do not hang if the
FailureStoreDocumentConverter fails for a reason we are not expecting.
Closes elastic#139707

(cherry picked from commit d3e0128)
elasticsearchmachine pushed a commit that referenced this pull request Jan 7, 2026
…expected exceptions (#139712) (#140269)

This makes sure that bulk requests do not hang if the
FailureStoreDocumentConverter fails for a reason we are not expecting.
Closes #139707

(cherry picked from commit d3e0128)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >bug :StorageEngine/Data streams Data streams and their lifecycles Team:Data Management (obsolete) DO NOT USE. This team no longer exists. v8.19.10 v9.1.10 v9.2.4 v9.3.1 v9.4.0

4 participants