Skip to content

GPU: add support for cosine with cuvs 2025.12#139821

Merged
elasticsearchmachine merged 8 commits intoelastic:mainfrom
mayya-sharipova:upgrade-cuvs-2025.12
Dec 23, 2025
Merged

GPU: add support for cosine with cuvs 2025.12#139821
elasticsearchmachine merged 8 commits intoelastic:mainfrom
mayya-sharipova:upgrade-cuvs-2025.12

Conversation

@mayya-sharipova
Copy link
Contributor

@mayya-sharipova mayya-sharipova commented Dec 19, 2025

Follow up for #139747
@elasticsearchmachine elasticsearchmachine added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Dec 19, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Dec 19, 2025

Hi @mayya-sharipova, I've created a changelog YAML for you.
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Dec 19, 2025

Pinging @elastic/es-search-relevance (Team:Search Relevance)
@mayya-sharipova mayya-sharipova added the test-gpu Run tests using a GPU label Dec 19, 2025
ChrisHegarty
ChrisHegarty approved these changes Dec 19, 2025
View reviewed changes
Copy link
Contributor

@ChrisHegarty ChrisHegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@mayya-sharipova mayya-sharipova added auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) auto-backport Automatically create backport pull requests when merged labels Dec 19, 2025
@mayya-sharipova
Copy link
Contributor Author

mayya-sharipova commented Dec 19, 2025

I have this unrelated test failing for gpu-tests:


> Task :x-pack:qa:kerberos-tests:javaRestTest
--
 
KerberosAuthenticationIT > classMethod FAILED
com.carrotsearch.randomizedtesting.ThreadLeakError: 1 thread leaked from SUITE scope at org.elasticsearch.xpack.security.authc.kerberos.KerberosAuthenticationIT:
1) Thread[id=68, name=JNA Cleaner, state=TIMED_WAITING, group=TGRP-KerberosAuthenticationIT]
at java.base/java.lang.Object.wait0(Native Method)
at java.base/java.lang.Object.wait(Object.java:389)
at java.base/java.lang.ref.ReferenceQueue.remove0(ReferenceQueue.java:123)
at java.base/java.lang.ref.ReferenceQueue.remove(ReferenceQueue.java:201)
at com.sun.jna.internal.Cleaner$CleanerThread.run(Cleaner.java:154)
at __randomizedtesting.SeedInfo.seed([D937BCB28A41778C]:0)
 
Tests with failures:
- org.elasticsearch.xpack.security.authc.kerberos.KerberosAuthenticationIT.classMethod

Relevan gpu tests don't fail, so I am disabling gpu-tests label.
@mayya-sharipova mayya-sharipova removed the test-gpu Run tests using a GPU label Dec 19, 2025
@elasticsearchmachine elasticsearchmachine merged commit 4d7a3e4 into elastic:main Dec 23, 2025
35 checks passed
@mayya-sharipova mayya-sharipova deleted the upgrade-cuvs-2025.12 branch December 23, 2025 17:03
@mayya-sharipova mayya-sharipova mentioned this pull request Dec 23, 2025
Merged
mayya-sharipova added a commit to mayya-sharipova/elasticsearch that referenced this pull request Dec 23, 2025
@mayya-sharipova
GPU: add support for cosine with cuvs 2025.12 (elastic#139821)
c709570 
Follow up for elastic#139747
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Dec 23, 2025

💚 Backport successful

Status Branch Result
✅ 9.3
elasticsearchmachine pushed a commit that referenced this pull request Dec 23, 2025
@mayya-sharipova
GPU: add support for cosine with cuvs 2025.12 (#139821) (#139967)
3ee71bc 
Follow up for #139747
rjernst pushed a commit to rjernst/elasticsearch that referenced this pull request Dec 29, 2025
@mayya-sharipova @rjernst
GPU: add support for cosine with cuvs 2025.12 (elastic#139821)
b7b0319 
Follow up for elastic#139747
mayya-sharipova added a commit to mayya-sharipova/elasticsearch that referenced this pull request Jan 8, 2026
@mayya-sharipova
GPU vector indexing: no cosine function
4b1242c 
Ensure cosine funciton is not used for GPU vector indexing,
as we ensure before that cosine is substituted with dot_product
and vectors are normalized.

Follow up for elastic#139821
@giladgal giladgal mentioned this pull request Feb 8, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >upgrade v9.3.1 v9.4.0

3 participants

@mayya-sharipova @elasticsearchmachine @ChrisHegarty