ESQL: Fix extent reading when missing#140034
Merged
nik9000 merged 2 commits intoelastic:mainfrom Dec 29, 2025
Merged
Conversation
Fixes a bug while reading spatial extents when the leaf doesn't contain any documents with a shape. These have a `null` `BinaryDocValues` and we can just read them as entirely `null` values like other readers.
nik9000
added
>bug
auto-backport
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Collaborator
|
Hi @nik9000, I've created a changelog YAML for you. |
GalLalouche
approved these changes
Dec 29, 2025
Member
Author
|
Thanks @GalLalouche. |
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Dec 29, 2025
Fixes a bug while reading spatial extents when the leaf doesn't contain any documents with a shape. These have a `null` `BinaryDocValues` and we can just read them as entirely `null` values like other readers.
Collaborator
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 29, 2025
Kubik42
pushed a commit
to Kubik42/elasticsearch
that referenced
this pull request
Dec 30, 2025
Fixes a bug while reading spatial extents when the leaf doesn't contain any documents with a shape. These have a `null` `BinaryDocValues` and we can just read them as entirely `null` values like other readers.
Contributor
|
Thanks @nik9000 ! |
Contributor
|
Wow! Thanks Nik. Mouhcine and I were also fixing this yesterday, but did not have failing tests in place before you got this done. I now have a failing integration test which this will also fix, and I'll make that PR a test-only PR now since the fix is already merged. |
craigtaverner
added a commit
to craigtaverner/elasticsearch
that referenced
this pull request
Dec 30, 2025
This test also fails when the indexes have 16 shards before the fix at elastic#140034
craigtaverner
added a commit
to craigtaverner/elasticsearch
that referenced
this pull request
Dec 30, 2025
This test also fails when the indexes have 16 shards before the fix at elastic#140034
Member
Author
|
Sorry for jumping on this without checking the assignees! Old habit back when we weren't piling on the test failures at the same time. I'll be more careful. |
craigtaverner
added a commit
to craigtaverner/elasticsearch
that referenced
this pull request
Dec 30, 2025
…stic#140057) This test also fails when the indexes have 16 shards before the fix at elastic#140034
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug while reading spatial extents when the leaf doesn't contain any documents with a shape. These have a
nullBinaryDocValuesand we can just read them as entirelynullvalues like other readers.