Skip to content

Reject max_number_of_allocations > 1 for low-priority model deployments#140163

Merged
jan-elastic merged 4 commits intoelastic:mainfrom
jan-elastic:disallow_low_prioty_max_allocs_greater_than_1
Jan 13, 2026
Merged

Reject max_number_of_allocations > 1 for low-priority model deployments#140163
jan-elastic merged 4 commits intoelastic:mainfrom
jan-elastic:disallow_low_prioty_max_allocs_greater_than_1

Conversation

@jan-elastic
Copy link
Contributor

@jan-elastic jan-elastic commented Jan 5, 2026

fixes #111227

@jan-elastic jan-elastic requested a review from prwhelan January 5, 2026 11:04
@jan-elastic jan-elastic added >non-issue :ml Machine learning Team:ML Meta label for the ML team auto-backport Automatically create backport pull requests when merged v9.2.4 v8.19.10 v9.3.1 v9.4.0 labels Jan 5, 2026
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

}
if (adaptiveAllocationsSettings != null
&& adaptiveAllocationsSettings.getMaxNumberOfAllocations() != null
&& adaptiveAllocationsSettings.getMaxNumberOfAllocations() > 1) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: there's no need to verify min_number_of_allocations, because it's already validated to be at most max_number_of_allocations.

@jan-elastic jan-elastic force-pushed the disallow_low_prioty_max_allocs_greater_than_1 branch from ea71ec3 to 0616114 Compare January 5, 2026 11:11
@jan-elastic jan-elastic changed the title Disallow max_number_of_allocation > 1 for low priority model deployments Jan 5, 2026
@elasticsearchmachine
Copy link
Collaborator

Hi @jan-elastic, I've created a changelog YAML for you.

@jan-elastic jan-elastic changed the title Disallow max_number_of_allocations > 1 for low priority model deployments Jan 5, 2026
@jan-elastic jan-elastic merged commit b7f345c into elastic:main Jan 13, 2026
34 of 35 checks passed
jan-elastic added a commit to jan-elastic/elasticsearch that referenced this pull request Jan 13, 2026
…ts (elastic#140163)

* Disallow max_number_of_allocation > 1 for low priority model deployments

* Update docs/changelog/140163.yaml

* blacklist test for security
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
9.3
8.19
9.2
jan-elastic added a commit to jan-elastic/elasticsearch that referenced this pull request Jan 13, 2026
…ts (elastic#140163)

* Disallow max_number_of_allocation > 1 for low priority model deployments

* Update docs/changelog/140163.yaml

* blacklist test for security
jan-elastic added a commit to jan-elastic/elasticsearch that referenced this pull request Jan 13, 2026
…ts (elastic#140163)

* Disallow max_number_of_allocation > 1 for low priority model deployments

* Update docs/changelog/140163.yaml

* blacklist test for security
elasticsearchmachine pushed a commit that referenced this pull request Jan 13, 2026
…ts (#140163) (#140543)

* Disallow max_number_of_allocation > 1 for low priority model deployments

* Update docs/changelog/140163.yaml

* blacklist test for security
elasticsearchmachine pushed a commit that referenced this pull request Jan 13, 2026
…ts (#140163) (#140544)

* Disallow max_number_of_allocation > 1 for low priority model deployments

* Update docs/changelog/140163.yaml

* blacklist test for security
elasticsearchmachine pushed a commit that referenced this pull request Jan 13, 2026
…ts (#140163) (#140542)

* Disallow max_number_of_allocation > 1 for low priority model deployments

* Update docs/changelog/140163.yaml

* blacklist test for security
eranweiss-elastic pushed a commit to eranweiss-elastic/elasticsearch that referenced this pull request Jan 15, 2026
…ts (elastic#140163)

* Disallow max_number_of_allocation > 1 for low priority model deployments

* Update docs/changelog/140163.yaml

* blacklist test for security
spinscale pushed a commit to spinscale/elasticsearch that referenced this pull request Jan 21, 2026
…ts (elastic#140163)

* Disallow max_number_of_allocation > 1 for low priority model deployments

* Update docs/changelog/140163.yaml

* blacklist test for security
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged >bug :ml Machine learning Team:ML Meta label for the ML team v8.19.11 v9.2.5 v9.3.1 v9.4.0

3 participants