Fix testAckListenerReceivesNacksIfPublicationTimesOut#140514
Merged
DaveCTurner merged 2 commits intoelastic:mainfrom Jan 12, 2026
Merged
Conversation
This test is kinda bogus with an atomic register because it doesn't actually time out as claimed. Nonetheless, we do want to know that the nacks are genuinely delivered eventually under these conditions. This commit adjusts the test to handle the relaxed a lag detector introduced in elastic#140434. Closes elastic#140509
DaveCTurner
added
>test
elasticsearchmachine
added
the
Team:Distributed Coordination (obsolete)
Collaborator
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
|
|
||
| follower0.heal(); | ||
| follower1.heal(); | ||
| cluster.stabilise(); |
Contributor
There was a problem hiding this comment.
Could you explain why this stabilise call doesn't lead to an eventual nack from the followers?
Contributor
Author
There was a problem hiding this comment.
It's in this comment:
// time out in this case. However, this means the nodes may remain lagging until the next cluster state update - there's no // master failover to resync them in this case. The nacks happen when the blackholed requests are processed.
server/src/test/java/org/elasticsearch/cluster/coordination/CoordinatorTests.java
Outdated
Show resolved
Hide resolved
DaveCTurner
deleted the
2026/01/12/testAckListenerReceivesNacksIfPublicationTimesOut-fix
branch
szybia
added a commit
to szybia/elasticsearch
that referenced
this pull request
Jan 12, 2026
…i-project-tests * upstream/main: (23 commits) Fix `testAckListenerReceivesNacksIfPublicationTimesOut` (elastic#140514) Reduce priority of clear-cache tasks (elastic#139685) Add docs and tests about `StreamOutput` to memory (elastic#140365) ES|QL - dense_vector support for COUNT, PRESENT, ABSENT aggregator functions (elastic#139914) Add release notes for v9.2.4 release (elastic#140487) Add release notes for v9.1.10 release (elastic#140488) Add conncectors release notes for 9.1.10, 9.2.4 (elastic#140499) Add parameter support in PromQL query durations (elastic#139873) Improve testing of STS credentials reloading (elastic#140114) Fix zstd native binary publishing script to support newer versions (elastic#140485) Add FlattenedFieldBinaryVsSortedSetDocValuesSyntheticSourceIT (elastic#140489) Store fallback match only text fields in binary doc values (elastic#140189) [DiskBBQ] Use the new merge executor for intra-merge parallelism (elastic#139942) ESQL: introduce support for mapping-unavailable fields (elastic#140463) Add ESNextOSQVectorsScorerTests (elastic#140436) Disable high cardinality tests on release builds (elastic#140503) ESQL: TRange timezone support (elastic#139911) Directly compressing `StreamOutput` (elastic#140502) ES|QL - fix dense vector enrich bug (elastic#139774) Use CrossProjectModeDecider in RemoteClusterService (elastic#140481) ...
spinscale
pushed a commit
to spinscale/elasticsearch
that referenced
this pull request
Jan 21, 2026
This test is kinda bogus with an atomic register because it doesn't actually time out as claimed. Nonetheless, we do want to know that the nacks are genuinely delivered eventually under these conditions. This commit adjusts the test to handle the relaxed lag detector introduced in elastic#140434. Closes elastic#140509
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test is kinda bogus with an atomic register because it doesn't
actually time out as claimed. Nonetheless, we do want to know that the
nacks are genuinely delivered eventually under these conditions. This
commit adjusts the test to handle the relaxed lag detector introduced
in #140434.
Closes #140509