ESQL: Enable nullify and fail unmapped resolution in tech-preview#140528
ESQL: Enable nullify and fail unmapped resolution in tech-preview#140528GalLalouche merged 16 commits intoelastic:mainfrom
Conversation
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Hi @GalLalouche, I've created a changelog YAML for you. |
|
|
||
| public void testSet() { | ||
| assumeTrue("SET command available in snapshot only", EsqlCapabilities.Cap.SET_COMMAND.isEnabled()); | ||
| assumeTrue("SET command required", EsqlCapabilities.Cap.SET_COMMAND.isEnabled()); |
There was a problem hiding this comment.
Apparently, SET no longer requires snapshot, so I've updated these comments in this file.
ℹ️ Important: Docs version tagging👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version. We use applies_to tags to mark version-specific features and changes. Expand for a quick overviewWhen to use applies_to tags:✅ At the page level to indicate which products/deployments the content applies to (mandatory) What NOT to do:❌ Don't remove or replace information that applies to an older version 🤔 Need help?
|
| } catch (ParsingException pe) { | ||
| throw pe; |
There was a problem hiding this comment.
Yes, since otherwise it would be swallowed up by the catch (Exception e) below it, which would lead to a very confusing error message :) In theory, we can probably do better than try/catch to begin with, but I didn't want to change whatever underlying logic existed, other than invalidating LOAD.
| verifySetUnmappedFields(List.of("FAIL", "NULLIFY")); | ||
|
|
||
| try { | ||
| statement("SET unmapped_fields=\"" + randomizeCase(UnmappedResolution.LOAD.name()) + "\"; row a = 1"); |
x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/plan/QuerySettingsTests.java
Outdated
Show resolved
Hide resolved
alex-spies
left a comment
There was a problem hiding this comment.
LGTM with minor comments only
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plan/QuerySettings.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plan/QuerySettings.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/parser/SetParserTests.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/parser/SetParserTests.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/parser/SetParserTests.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/plan/QuerySettingsTests.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/plan/QuerySettingsTests.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/plan/QuerySettingsTests.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/parser/SetParserTests.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/plan/QuerySettingsTests.java
Outdated
Show resolved
Hide resolved
…Lalouche/elasticsearch into feat/set_unmapped_nullify_keyword_tp
💔 Backport failed
You can use sqren/backport to manually backport by running |
…astic#140528) This PR removes the snapshot protection of FAIL and NULLIFY options for unmapped fields (only LOAD remains protected under snapshot). Follow up to elastic#140463. Related: elastic#138888.
…ew (#140528) (#140657) * ESQL: Enable nullify and fail unmapped resolution in tech-preview (#140528) This PR removes the snapshot protection of FAIL and NULLIFY options for unmapped fields (only LOAD remains protected under snapshot). Follow up to #140463. Related: #138888. * Fix statsAggs tests --------- Co-authored-by: Alexander Spies <alexander.spies@elastic.co>
…astic#140528) This PR removes the snapshot protection of FAIL and NULLIFY options for unmapped fields (only LOAD remains protected under snapshot). Follow up to elastic#140463. Related: elastic#138888.
This PR removes the snapshot protection of
FAILandNULLIFYoptions for unmapped fields (onlyLOADremains protected under snapshot).Follow up to #140463.
Related: #138888.