Corrects a seemingly simple bug where we pass numCands instead of k#140839
Merged
elasticsearchmachine merged 8 commits intoelastic:mainfrom Jan 17, 2026
Merged
Corrects a seemingly simple bug where we pass numCands instead of k#140839elasticsearchmachine merged 8 commits intoelastic:mainfrom
elasticsearchmachine merged 8 commits intoelastic:mainfrom
Conversation
elasticsearchmachine
added
the
Team:Search Relevance
Collaborator
|
Hi @benwtrent, I've created a changelog YAML for you. |
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
jimczi
approved these changes
Jan 16, 2026
Contributor
jimczi
left a comment
jimczi
left a comment
There was a problem hiding this comment.
LGTM, ++ to backport as well.
benwtrent
added
auto-merge-without-approval
mayya-sharipova
approved these changes
Jan 16, 2026
Contributor
mayya-sharipova
left a comment
mayya-sharipova
left a comment
There was a problem hiding this comment.
Thanks @benwtrent , makes sense
Collaborator
💚 Backport successful
|
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Jan 17, 2026
…lastic#140839) Digging through the long and sordid history of this class, I noticed we previously passed in `null`, which would indicate "dynamic K" which defaulted to the size of the request. However, in an effort to simplify the APIs when we rewrote these paths for rescoring, I switched this to numCands. But, since then @pmpailis actually fixed all the default logic in the `Builder#build(int)` parameter, correctly defaulting `k` and `numCands`. So, we SHOULD be able to pass in `k`. A quick check of our yaml tests and they all passed...let's see what CI says. While this is a bug, it would adjust behavior slightly, so only considering the latest bugfix. I could be convinced to backport everywhere if CI is happy.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 17, 2026
…140839) (#140852) Digging through the long and sordid history of this class, I noticed we previously passed in `null`, which would indicate "dynamic K" which defaulted to the size of the request. However, in an effort to simplify the APIs when we rewrote these paths for rescoring, I switched this to numCands. But, since then @pmpailis actually fixed all the default logic in the `Builder#build(int)` parameter, correctly defaulting `k` and `numCands`. So, we SHOULD be able to pass in `k`. A quick check of our yaml tests and they all passed...let's see what CI says. While this is a bug, it would adjust behavior slightly, so only considering the latest bugfix. I could be convinced to backport everywhere if CI is happy.
spinscale
pushed a commit
to spinscale/elasticsearch
that referenced
this pull request
Jan 21, 2026
…lastic#140839) Digging through the long and sordid history of this class, I noticed we previously passed in `null`, which would indicate "dynamic K" which defaulted to the size of the request. However, in an effort to simplify the APIs when we rewrote these paths for rescoring, I switched this to numCands. But, since then @pmpailis actually fixed all the default logic in the `Builder#build(int)` parameter, correctly defaulting `k` and `numCands`. So, we SHOULD be able to pass in `k`. A quick check of our yaml tests and they all passed...let's see what CI says. While this is a bug, it would adjust behavior slightly, so only considering the latest bugfix. I could be convinced to backport everywhere if CI is happy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Digging through the long and sordid history of this class, I noticed we previously passed in
null, which would indicate "dynamic K" which defaulted to the size of the request.However, in an effort to simplify the APIs when we rewrote these paths for rescoring, I switched this to numCands.
But, since then @pmpailis actually fixed all the default logic in the
Builder#build(int)parameter, correctly defaultingkandnumCands.So, we SHOULD be able to pass in
k. A quick check of our yaml tests and they all passed...let's see what CI says.While this is a bug, it would adjust behavior slightly, so only considering the latest bugfix. I could be convinced to backport everywhere if CI is happy.