Remove ILM-stopped-check before the cluster update in migrateToDataTiersRouting (#140885)#140892
Merged
elasticsearchmachine merged 7 commits intoelastic:mainfrom Jan 20, 2026
Merged
Conversation
gmarouli
added
auto-backport
elasticsearchmachine
added
v9.4.0
v9.3.1
v9.1.11
v9.2.5
Team:StorageEngine
and removed
branch:9.2
branch:9.1
branch:9.3
labels
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Collaborator
|
Hi @gmarouli, I've created a changelog YAML for you. |
gmarouli
commented
Jan 19, 2026
docs/changelog/140892.yaml
Outdated
| @@ -0,0 +1,6 @@ | |||
| pr: 140892 | |||
| summary: Remove ILM-stopped-check before the cluster update in `migrateToDataTiersRouting` | |||
| area: ILM+SLM | |||
Contributor
Author
There was a problem hiding this comment.
I have opened #140895 to fix the area labels
gmarouli
added
the
auto-merge-without-approval
gmarouli
added a commit
to gmarouli/elasticsearch
that referenced
this pull request
Jan 20, 2026
…iersRouting` (elastic#140885) (elastic#140892) In order to run the migrate data tiers request, we need to ensure that ILM is stopped. In the `TransportMigrateToDataTiersAction` we performed this check twice: 1. The first time was when the API was called to avoid creating cluster state updates that were bound to fail. 2. The second time was during the cluster state update, to ensure that the cluster state has the correct conditions when applying the change. It is possible that the first check is applied on an outdated cluster state causing the request to fail while it could succeed. In this PR, considering the usage patterns of this API, we believe the benefit of the first check is very small, so we keep only the second which is the up-to-date one. Relevant test: https://github.com/elastic/elasticsearch/blob/main/x-pack/plugin/ilm/qa/multi-node/src/javaRestTest/java/org/elasticsearch/xpack/MigrateToDataTiersIT.java#L82-L87 Fixes elastic#140885
gmarouli
added a commit
to gmarouli/elasticsearch
that referenced
this pull request
Jan 20, 2026
…iersRouting` (elastic#140885) (elastic#140892) In order to run the migrate data tiers request, we need to ensure that ILM is stopped. In the `TransportMigrateToDataTiersAction` we performed this check twice: 1. The first time was when the API was called to avoid creating cluster state updates that were bound to fail. 2. The second time was during the cluster state update, to ensure that the cluster state has the correct conditions when applying the change. It is possible that the first check is applied on an outdated cluster state causing the request to fail while it could succeed. In this PR, considering the usage patterns of this API, we believe the benefit of the first check is very small, so we keep only the second which is the up-to-date one. Relevant test: https://github.com/elastic/elasticsearch/blob/main/x-pack/plugin/ilm/qa/multi-node/src/javaRestTest/java/org/elasticsearch/xpack/MigrateToDataTiersIT.java#L82-L87 Fixes elastic#140885
Collaborator
gmarouli
added a commit
to gmarouli/elasticsearch
that referenced
this pull request
Jan 20, 2026
…iersRouting` (elastic#140885) (elastic#140892) In order to run the migrate data tiers request, we need to ensure that ILM is stopped. In the `TransportMigrateToDataTiersAction` we performed this check twice: 1. The first time was when the API was called to avoid creating cluster state updates that were bound to fail. 2. The second time was during the cluster state update, to ensure that the cluster state has the correct conditions when applying the change. It is possible that the first check is applied on an outdated cluster state causing the request to fail while it could succeed. In this PR, considering the usage patterns of this API, we believe the benefit of the first check is very small, so we keep only the second which is the up-to-date one. Relevant test: https://github.com/elastic/elasticsearch/blob/main/x-pack/plugin/ilm/qa/multi-node/src/javaRestTest/java/org/elasticsearch/xpack/MigrateToDataTiersIT.java#L82-L87 Fixes elastic#140885
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 20, 2026
…iersRouting` (#140885) (#140892) (#140950) In order to run the migrate data tiers request, we need to ensure that ILM is stopped. In the `TransportMigrateToDataTiersAction` we performed this check twice: 1. The first time was when the API was called to avoid creating cluster state updates that were bound to fail. 2. The second time was during the cluster state update, to ensure that the cluster state has the correct conditions when applying the change. It is possible that the first check is applied on an outdated cluster state causing the request to fail while it could succeed. In this PR, considering the usage patterns of this API, we believe the benefit of the first check is very small, so we keep only the second which is the up-to-date one. Relevant test: https://github.com/elastic/elasticsearch/blob/main/x-pack/plugin/ilm/qa/multi-node/src/javaRestTest/java/org/elasticsearch/xpack/MigrateToDataTiersIT.java#L82-L87 Fixes #140885
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 20, 2026
…iersRouting` (#140885) (#140892) (#140949) In order to run the migrate data tiers request, we need to ensure that ILM is stopped. In the `TransportMigrateToDataTiersAction` we performed this check twice: 1. The first time was when the API was called to avoid creating cluster state updates that were bound to fail. 2. The second time was during the cluster state update, to ensure that the cluster state has the correct conditions when applying the change. It is possible that the first check is applied on an outdated cluster state causing the request to fail while it could succeed. In this PR, considering the usage patterns of this API, we believe the benefit of the first check is very small, so we keep only the second which is the up-to-date one. Relevant test: https://github.com/elastic/elasticsearch/blob/main/x-pack/plugin/ilm/qa/multi-node/src/javaRestTest/java/org/elasticsearch/xpack/MigrateToDataTiersIT.java#L82-L87 Fixes #140885
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 20, 2026
…iersRouting` (#140885) (#140892) (#140951) In order to run the migrate data tiers request, we need to ensure that ILM is stopped. In the `TransportMigrateToDataTiersAction` we performed this check twice: 1. The first time was when the API was called to avoid creating cluster state updates that were bound to fail. 2. The second time was during the cluster state update, to ensure that the cluster state has the correct conditions when applying the change. It is possible that the first check is applied on an outdated cluster state causing the request to fail while it could succeed. In this PR, considering the usage patterns of this API, we believe the benefit of the first check is very small, so we keep only the second which is the up-to-date one. Relevant test: https://github.com/elastic/elasticsearch/blob/main/x-pack/plugin/ilm/qa/multi-node/src/javaRestTest/java/org/elasticsearch/xpack/MigrateToDataTiersIT.java#L82-L87 Fixes #140885
spinscale
pushed a commit
to spinscale/elasticsearch
that referenced
this pull request
Jan 21, 2026
…iersRouting` (elastic#140885) (elastic#140892) In order to run the migrate data tiers request, we need to ensure that ILM is stopped. In the `TransportMigrateToDataTiersAction` we performed this check twice: 1. The first time was when the API was called to avoid creating cluster state updates that were bound to fail. 2. The second time was during the cluster state update, to ensure that the cluster state has the correct conditions when applying the change. It is possible that the first check is applied on an outdated cluster state causing the request to fail while it could succeed. In this PR, considering the usage patterns of this API, we believe the benefit of the first check is very small, so we keep only the second which is the up-to-date one. Relevant test: https://github.com/elastic/elasticsearch/blob/main/x-pack/plugin/ilm/qa/multi-node/src/javaRestTest/java/org/elasticsearch/xpack/MigrateToDataTiersIT.java#L82-L87 Fixes elastic#140885
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to run the migrate data tiers request, we need to ensure that ILM is stopped. In the
TransportMigrateToDataTiersActionwe performed this check twice:It is possible that the first check is applied on an outdated cluster state causing the request to fail while it could succeed.
In this PR, considering the usage patterns of this API, we believe the benefit of the first check is very small, so we keep only the second which is the up-to-date one.
Relevant test:
https://github.com/elastic/elasticsearch/blob/main/x-pack/plugin/ilm/qa/multi-node/src/javaRestTest/java/org/elasticsearch/xpack/MigrateToDataTiersIT.java#L82-L87
Fixes #140885