Ensure we parse on_disk_rescore as its valid to pass false#141158
Merged
elasticsearchmachine merged 3 commits intoelastic:mainfrom Jan 23, 2026
Merged
Ensure we parse on_disk_rescore as its valid to pass false#141158elasticsearchmachine merged 3 commits intoelastic:mainfrom
elasticsearchmachine merged 3 commits intoelastic:mainfrom
Conversation
benwtrent
added
>bug
auto-backport
elasticsearchmachine
added
the
Team:Search Relevance
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
thecoop
approved these changes
Jan 23, 2026
server/src/main/java/org/elasticsearch/index/mapper/vectors/DenseVectorFieldMapper.java
Outdated
Show resolved
Hide resolved
…nseVectorFieldMapper.java Co-authored-by: Simon Cooper <simon.cooper@elastic.co>
benwtrent
added
the
auto-merge-without-approval
Collaborator
|
Hi @benwtrent, I've created a changelog YAML for you. |
Collaborator
💚 Backport successful
|
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Jan 23, 2026
…41158) its valid to pass false for on_disk_rescore for all index mapping types. We should parse the key to validate. I noticed this when changing combinations in our rally tracks :) (which defaults to sending a false value).
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 23, 2026
…141191) its valid to pass false for on_disk_rescore for all index mapping types. We should parse the key to validate. I noticed this when changing combinations in our rally tracks :) (which defaults to sending a false value).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
its valid to pass false for on_disk_rescore for all index mapping types. We should parse the key to validate.
I noticed this when changing combinations in our rally tracks :) (which defaults to sending a false value).