Skip to content

Allow include_source_on_error param on logs streams#141391

Merged
seanzatzdev merged 4 commits intoelastic:mainfrom
seanzatzdev:add-streams-params
Jan 28, 2026
Merged

Allow include_source_on_error param on logs streams#141391
seanzatzdev merged 4 commits intoelastic:mainfrom
seanzatzdev:add-streams-params

Conversation

@seanzatzdev
Copy link
Contributor

Closes #141360

@elasticsearchmachine elasticsearchmachine added v9.4.0 needs:triage Requires assignment of a team area label labels Jan 27, 2026
@seanzatzdev seanzatzdev requested a review from Copilot January 27, 2026 19:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for the include_source_on_error parameter for log streams in the bulk API. The change addresses issue #141360 by allowing this parameter to be passed through the API.

Changes:

  • Added include_source_on_error to the list of allowed bulk API parameters

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Jan 27, 2026
@elasticsearchmachine
Copy link
Collaborator

Hi @seanzatzdev, I've created a changelog YAML for you.

@seanzatzdev seanzatzdev merged commit b5bba2a into elastic:main Jan 28, 2026
35 checks passed
@seanzatzdev seanzatzdev deleted the add-streams-params branch January 28, 2026 14:55
@xeraa
Copy link
Contributor

xeraa commented Jan 28, 2026

Are we backporting this one?

@seanzatzdev seanzatzdev added auto-backport Automatically create backport pull requests when merged v9.3.0 v9.3.1 v8.19.12 and removed v9.3.0 auto-backport Automatically create backport pull requests when merged labels Feb 5, 2026
seanzatzdev added a commit to seanzatzdev/elasticsearch that referenced this pull request Feb 5, 2026
* allow include_source_on_error param on logs streams

* Update docs/changelog/141391.yaml

(cherry picked from commit b5bba2a)
@seanzatzdev
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
9.3
8.19

Questions ?

Please refer to the Backport tool documentation

seanzatzdev added a commit to seanzatzdev/elasticsearch that referenced this pull request Feb 5, 2026
* allow include_source_on_error param on logs streams

* Update docs/changelog/141391.yaml

(cherry picked from commit b5bba2a)

# Conflicts:
#	server/src/main/java/org/elasticsearch/action/bulk/TransportAbstractBulkAction.java
@seanzatzdev
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.19

Questions ?

Please refer to the Backport tool documentation

seanzatzdev added a commit to seanzatzdev/elasticsearch that referenced this pull request Feb 6, 2026
* allow include_source_on_error param on logs streams

* Update docs/changelog/141391.yaml

(cherry picked from commit b5bba2a)

# Conflicts:
#	server/src/main/java/org/elasticsearch/action/bulk/TransportAbstractBulkAction.java
@seanzatzdev
Copy link
Contributor Author

I've opened a 9.3 backport PR. I'm hesitant to backport to 8.19 as it seems there would be quite a bit of refactoring involved, and I'm concerned that the risk may outweigh the reward.

elasticsearchmachine pushed a commit that referenced this pull request Feb 6, 2026
* allow include_source_on_error param on logs streams

* Update docs/changelog/141391.yaml

(cherry picked from commit b5bba2a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged >bug :StorageEngine/Data streams Data streams and their lifecycles Team:StorageEngine v8.19.12 v9.3.1 v9.4.0

6 participants