Allow include_source_on_error param on logs streams#141391
Merged
seanzatzdev merged 4 commits intoelastic:mainfrom Jan 28, 2026
Merged
Allow include_source_on_error param on logs streams#141391seanzatzdev merged 4 commits intoelastic:mainfrom
seanzatzdev merged 4 commits intoelastic:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for the include_source_on_error parameter for log streams in the bulk API. The change addresses issue #141360 by allowing this parameter to be passed through the API.
Changes:
- Added
include_source_on_errorto the list of allowed bulk API parameters
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Collaborator
|
Hi @seanzatzdev, I've created a changelog YAML for you. |
Kubik42
approved these changes
Jan 27, 2026
lukewhiting
approved these changes
Jan 27, 2026
Contributor
|
Are we backporting this one? |
seanzatzdev
added a commit
to seanzatzdev/elasticsearch
that referenced
this pull request
Feb 5, 2026
* allow include_source_on_error param on logs streams * Update docs/changelog/141391.yaml (cherry picked from commit b5bba2a)
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
seanzatzdev
added a commit
to seanzatzdev/elasticsearch
that referenced
this pull request
Feb 5, 2026
* allow include_source_on_error param on logs streams * Update docs/changelog/141391.yaml (cherry picked from commit b5bba2a) # Conflicts: # server/src/main/java/org/elasticsearch/action/bulk/TransportAbstractBulkAction.java
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
seanzatzdev
added a commit
to seanzatzdev/elasticsearch
that referenced
this pull request
Feb 6, 2026
* allow include_source_on_error param on logs streams * Update docs/changelog/141391.yaml (cherry picked from commit b5bba2a) # Conflicts: # server/src/main/java/org/elasticsearch/action/bulk/TransportAbstractBulkAction.java
Contributor
Author
|
I've opened a 9.3 backport PR. I'm hesitant to backport to 8.19 as it seems there would be quite a bit of refactoring involved, and I'm concerned that the risk may outweigh the reward. |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #141360