ESQL fix TO_IP leading_zeros=octal parsing#141776
Merged
cimequinox merged 6 commits intoelastic:mainfrom Feb 4, 2026
Merged
Conversation
Apply fix and add expected warnings to test
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Collaborator
|
Hi @cimequinox, I've created a changelog YAML for you. |
nik9000
approved these changes
Feb 3, 2026
x-pack/plugin/esql/qa/testFixtures/src/main/resources/ip.csv-spec
Outdated
Show resolved
Hide resolved
cimequinox
added
auto-backport
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
cimequinox
added a commit
to cimequinox/elasticsearch
that referenced
this pull request
Feb 4, 2026
* Adds the check proposed by @strawgate so that TO_IP(input, {"leading_zeros":"octal"}) returns a proper error when the input is invalid. * Adds a test to ip.csv-spec to verify the fix. * Adds a capability fix_to_ip_leading_zeros_octal to control the test. * Resolves elastic#141627 (cherry picked from commit 994c46b) # Conflicts: # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/action/EsqlCapabilities.java
cimequinox
added a commit
to cimequinox/elasticsearch
that referenced
this pull request
Feb 4, 2026
* Adds the check proposed by @strawgate so that TO_IP(input, {"leading_zeros":"octal"}) returns a proper error when the input is invalid. * Adds a test to ip.csv-spec to verify the fix. * Adds a capability fix_to_ip_leading_zeros_octal to control the test. * Resolves elastic#141627 (cherry picked from commit 994c46b) # Conflicts: # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/action/EsqlCapabilities.java
Contributor
Author
💔 Some backports could not be created
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
cimequinox
added a commit
that referenced
this pull request
Feb 5, 2026
Backports #141776 to 9.3: * Adds the check proposed by @strawgate so that TO_IP(input, {"leading_zeros":"octal"}) returns a proper error when the input is invalid. * Adds a test to ip.csv-spec to verify the fix. * Adds a capability fix_to_ip_leading_zeros_octal to control the test. * Resolves #141627 (cherry picked from commit 994c46b)
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
mamazzol
pushed a commit
to mamazzol/elasticsearch
that referenced
this pull request
Feb 5, 2026
* Adds the check proposed by @strawgate so that TO_IP(input, {"leading_zeros":"octal"}) returns a proper error when the input is invalid. * Adds a test to ip.csv-spec to verify the fix. * Adds a capability fix_to_ip_leading_zeros_octal to control the test. * Resolves elastic#141627
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 5, 2026
* Adds the check proposed by @strawgate so that TO_IP(input, {"leading_zeros":"octal"}) returns a proper error when the input is invalid. * Adds a test to ip.csv-spec to verify the fix. * Adds a capability fix_to_ip_leading_zeros_octal to control the test. * Resolves #141627 (cherry picked from commit 994c46b) # Conflicts: # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/action/EsqlCapabilities.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 5, 2026
* Adds the check proposed by @strawgate so that TO_IP(input, {"leading_zeros":"octal"}) returns a proper error when the input is invalid. * Adds a test to ip.csv-spec to verify the fix. * Adds a capability fix_to_ip_leading_zeros_octal to control the test. * Resolves #141627 (cherry picked from commit 994c46b) # Conflicts: # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/action/EsqlCapabilities.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TO_IP(input, {"leading_zeros":"octal"})returns a proper error when the input is invalid.
ip.csv-specto verify the fix.fix_to_ip_leading_zeros_octalto control the test.