Prevent large CancelTasksRequest descriptions by truncating nodes and actions#141815
Merged
drempapis merged 4 commits intoelastic:mainfrom Feb 4, 2026
Merged
Conversation
drempapis
added
>bug
Team:Search Foundations
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
drempapis
added
auto-backport
Contributor
Author
💔 Some backports could not be created
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
drempapis
added a commit
to drempapis/elasticsearch
that referenced
this pull request
Feb 4, 2026
… actions (elastic#141815) (cherry picked from commit 099e10f)
drempapis
added a commit
to drempapis/elasticsearch
that referenced
this pull request
Feb 4, 2026
… actions (elastic#141815) (cherry picked from commit 099e10f)
kosabogi
pushed a commit
to kosabogi/elasticsearch
that referenced
this pull request
Feb 4, 2026
DaveCTurner
reviewed
Feb 4, 2026
Contributor
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
A possible alternative would be to use org.elasticsearch.common.Strings.BoundedDelimitedStringCollector (limits by string length rather than item count)
Contributor
Author
Thank you @DaveCTurner for the feedback. This approach sounds more appropriate. I’ll rework it based on this implementation. |
mamazzol
pushed a commit
to mamazzol/elasticsearch
that referenced
this pull request
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When cancelling a potentially large number of tasks, CancelTasksRequest#getDescription() may return very large logging the full nodes and actions arrays. This can lead to unnecessary memory usage and increased GC pressure.
This change limits the number of elements included in the description to 10 items per array, appending a "... (N more)" suffix when truncation occurs.
closes #141740