[Inference API] Do not write "task" field in Jina embedding request if unsupported#142181
Merged
DonalEvans merged 5 commits intoelastic:mainfrom Feb 10, 2026
Merged
Conversation
If the model being used does not support the specified InputType, do not write the "task" field when sending a request to JinaAI. More specifically, for jina-clip-v2, do not write the "task" field for InputType values other than SEARCH and INTERNAL_SEARCH.
DonalEvans
added
>bug
Feature:GenAI
Collaborator
|
Pinging @elastic/search-inference-team (Team:Search - Inference) |
Collaborator
|
Hi @DonalEvans, I've created a changelog YAML for you. |
jonathan-buttner
approved these changes
Feb 10, 2026
| // Do not specify the "task" field if the provided input type is not supported by the model | ||
| JinaAIEmbeddingsTaskSettings taskSettings = model.getTaskSettings(); | ||
| if (InputType.isSpecified(inputType)) { | ||
| if (InputType.isSpecified(inputType) && modelSupportsInputType(model, inputType)) { |
Contributor
There was a problem hiding this comment.
I think this might be a bit easier to read if we separated the if blocks. Something like this:
InputType inputTypeToUse;
if (InputType.isSpecified(inputType)) {
inputTypeToUse = inputType;
} else {
inputTypeToUse = taskSettings.getInputType();
}
if (inputTypeToUse != null && modelSupportsInputType(model, inputTypeToUse)) {
builder.field(TASK_TYPE_FIELD, convertInputType(inputTypeToUse));
}
Or maybe have the null check within modelSupportsInputType().
DonalEvans
added
auto-backport
elasticsearchmachine
added
v9.3.1
v8.19.12
v9.2.6
and removed
branch:9.2
branch:8.19
branch:9.3
labels
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
DonalEvans
added a commit
to DonalEvans/elasticsearch
that referenced
this pull request
Feb 10, 2026
…f unsupported (elastic#142181) If the model being used does not support the specified InputType, do not write the "task" field when sending a request to JinaAI. More specifically, for jina-clip-v2, do not write the "task" field for InputType values other than SEARCH and INTERNAL_SEARCH. (cherry picked from commit d08631b) # Conflicts: # x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/jinaai/request/JinaAIEmbeddingsRequestEntity.java # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/jinaai/JinaAIServiceTests.java # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/jinaai/request/JinaAIEmbeddingsRequestEntityTests.java
DonalEvans
added a commit
to DonalEvans/elasticsearch
that referenced
this pull request
Feb 10, 2026
…f unsupported (elastic#142181) If the model being used does not support the specified InputType, do not write the "task" field when sending a request to JinaAI. More specifically, for jina-clip-v2, do not write the "task" field for InputType values other than SEARCH and INTERNAL_SEARCH. (cherry picked from commit d08631b) # Conflicts: # x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/jinaai/request/JinaAIEmbeddingsRequestEntity.java # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/jinaai/JinaAIServiceTests.java # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/jinaai/request/JinaAIEmbeddingsRequestEntityTests.java
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 10, 2026
…f unsupported (#142181) (#142264) If the model being used does not support the specified InputType, do not write the "task" field when sending a request to JinaAI. More specifically, for jina-clip-v2, do not write the "task" field for InputType values other than SEARCH and INTERNAL_SEARCH. (cherry picked from commit d08631b) # Conflicts: # x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/jinaai/request/JinaAIEmbeddingsRequestEntity.java # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/jinaai/JinaAIServiceTests.java # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/jinaai/request/JinaAIEmbeddingsRequestEntityTests.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 10, 2026
…f unsupported (#142181) (#142265) If the model being used does not support the specified InputType, do not write the "task" field when sending a request to JinaAI. More specifically, for jina-clip-v2, do not write the "task" field for InputType values other than SEARCH and INTERNAL_SEARCH. (cherry picked from commit d08631b) # Conflicts: # x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/jinaai/request/JinaAIEmbeddingsRequestEntity.java # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/jinaai/JinaAIServiceTests.java # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/jinaai/request/JinaAIEmbeddingsRequestEntityTests.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 10, 2026
…f unsupported (#142181) (#142263) If the model being used does not support the specified InputType, do not write the "task" field when sending a request to JinaAI. More specifically, for jina-clip-v2, do not write the "task" field for InputType values other than SEARCH and INTERNAL_SEARCH. (cherry picked from commit d08631b) # Conflicts: # x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/jinaai/request/JinaAIEmbeddingsRequestEntity.java # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/jinaai/JinaAIServiceTests.java # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/jinaai/request/JinaAIEmbeddingsRequestEntityTests.java
costin
pushed a commit
to costin/elasticsearch
that referenced
this pull request
Feb 16, 2026
…f unsupported (elastic#142181) If the model being used does not support the specified InputType, do not write the "task" field when sending a request to JinaAI. More specifically, for jina-clip-v2, do not write the "task" field for InputType values other than SEARCH and INTERNAL_SEARCH.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the model being used does not support the specified InputType, do not write the "task" field when sending a request to JinaAI. More specifically, for jina-clip-v2, do not write the "task" field for InputType values other than SEARCH and INTERNAL_SEARCH.