Skip to content

Terminate S3 get blob retries when node is shutting down#142186

Merged
nicktindall merged 3 commits intoelastic:mainfrom
nicktindall:s3_terminate_retries_on_non_sdk_exceptions
Feb 10, 2026
Merged

Terminate S3 get blob retries when node is shutting down#142186
nicktindall merged 3 commits intoelastic:mainfrom
nicktindall:s3_terminate_retries_on_non_sdk_exceptions

Conversation

@nicktindall
Copy link
Contributor

This was a regression introduced when we factored out the RetryingInputStream. The logic changed such that the S3 implementation no longer aborted retries when an IllegalStateException was thrown, such as is the case when the repository is closed.

@nicktindall nicktindall added >bug :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs auto-backport Automatically create backport pull requests when merged v9.3.1 labels Feb 10, 2026
@elasticsearchmachine elasticsearchmachine added v9.4.0 Team:Distributed Meta label for distributed team. labels Feb 10, 2026
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@elasticsearchmachine
Copy link
Collaborator

Hi @nicktindall, I've created a changelog YAML for you.

@elasticsearchmachine elasticsearchmachine added the serverless-linked Added by automation, don't add manually label Feb 10, 2026
@nicktindall nicktindall requested a review from ywangd February 10, 2026 05:19
Copy link
Member

@ywangd ywangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for fixing it.

@ywangd
Copy link
Member

ywangd commented Feb 10, 2026

Btw, Azure's isRetryableException looks suspicious. I wonder wehether it could suffer from the same issue.

@nicktindall
Copy link
Contributor Author

Btw, Azure's isRetryableException looks suspicious. I wonder wehether it could suffer from the same issue.

Yes it does, I'm working on a fix now, I'll check GCP as well

@nicktindall nicktindall changed the title Terminate S3 get blob retries on non-SDK exceptions Feb 10, 2026
@nicktindall nicktindall enabled auto-merge (squash) February 10, 2026 07:47
@nicktindall nicktindall disabled auto-merge February 10, 2026 07:47
@nicktindall nicktindall enabled auto-merge (squash) February 10, 2026 07:47
@nicktindall nicktindall merged commit 36f95f8 into elastic:main Feb 10, 2026
35 checks passed
@nicktindall nicktindall deleted the s3_terminate_retries_on_non_sdk_exceptions branch February 11, 2026 01:38
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
9.3
nicktindall added a commit to nicktindall/elasticsearch that referenced this pull request Feb 11, 2026
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

The backport operation could not be completed due to the following error:

There are no branches to backport to. Aborting.

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 142186

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged backport pending >bug :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs serverless-linked Added by automation, don't add manually Team:Distributed Meta label for distributed team. v9.3.1 v9.4.0

3 participants