Terminate S3 get blob retries when node is shutting down#142186
Merged
nicktindall merged 3 commits intoelastic:mainfrom Feb 10, 2026
Merged
Terminate S3 get blob retries when node is shutting down#142186nicktindall merged 3 commits intoelastic:mainfrom
nicktindall merged 3 commits intoelastic:mainfrom
Conversation
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
Collaborator
|
Hi @nicktindall, I've created a changelog YAML for you. |
Member
|
Btw, Azure's isRetryableException looks suspicious. I wonder wehether it could suffer from the same issue. |
Contributor
Author
Yes it does, I'm working on a fix now, I'll check GCP as well |
Collaborator
💚 Backport successful
|
nicktindall
added a commit
to nicktindall/elasticsearch
that referenced
this pull request
Feb 11, 2026
Collaborator
💔 Backport failedThe backport operation could not be completed due to the following error: You can use sqren/backport to manually backport by running |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a regression introduced when we factored out the
RetryingInputStream. The logic changed such that the S3 implementation no longer aborted retries when anIllegalStateExceptionwas thrown, such as is the case when the repository is closed.