remove index.lifecycle.skip setting#34823
Merged
talevy merged 3 commits intoelastic:index-lifecyclefrom Oct 25, 2018
Merged
Conversation
With the introduction of _ilm/stop and _ilm/start APIs, the use cases where one would only target a select group of indices to start/stop has been reduced. Since there is no strong use-case for skipping specific indices, it is best to remove this functionality and only adding if later desired, with the hopes of keeping things more simple.
talevy
added
the
:Data Management/ILM+SLM
Collaborator
|
Pinging @elastic/es-core-infra |
Contributor
Author
|
thanks for the review @colings86. 🤞 |
Contributor
Author
|
test this please |
gwbrown
reviewed
Oct 24, 2018
Contributor
There was a problem hiding this comment.
LGTM too, assuming CI is green.
One note: https://github.com/elastic/elasticsearch/blob/index-lifecycle/x-pack/docs/en/ilm/pause-resume-ilm.asciidoc still mentions that "ILM can be skipped on a per-index basis", but since that isn't actual documentation yet it's probably fine. This doc is changed in your other PR, ignore this comment.
gwbrown
approved these changes
Oct 24, 2018
Contributor
gwbrown
left a comment
gwbrown
left a comment
There was a problem hiding this comment.
In case it wasn't clear I meant to approve this rather than just comment.
Contributor
Author
|
test this please |
talevy
added a commit
that referenced
this pull request
Oct 25, 2018
With the introduction of _ilm/stop and _ilm/start APIs, the use cases where one would only target a select group of indices to start/stop has been reduced. Since there is no strong use-case for skipping specific indices, it is best to remove this functionality and only adding if later desired, with the hopes of keeping things more simple.
nielsbauman
added a commit
to nielsbauman/elasticsearch
that referenced
this pull request
Jun 2, 2025
We want to be able to skip specific indices in ILM again for elastic#109206. This is essentially just a revert of elastic#34823.
nielsbauman
added a commit
that referenced
this pull request
Jun 3, 2025
nielsbauman
added a commit
to nielsbauman/elasticsearch
that referenced
this pull request
Jun 4, 2025
We want to be able to skip specific indices in ILM again for elastic#109206. This is essentially just a revert of elastic#34823. (cherry picked from commit 269fbbc) # Conflicts: # server/src/main/java/org/elasticsearch/TransportVersions.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the introduction of _ilm/stop and _ilm/start APIs, the
use cases where one would only target a select group
of indices to start/stop has been reduced. Since there is no
strong use-case for skipping specific indices, it is best to
remove this functionality and only adding if later desired, with the
hopes of keeping things more simple.