Skip to content

Wait for events in waitForRelocation#45074

Merged
DaveCTurner merged 3 commits intoelastic:masterfrom
DaveCTurner:2019-08-01-wait-for-relocations-and-events
Aug 1, 2019
Merged

Wait for events in waitForRelocation#45074
DaveCTurner merged 3 commits intoelastic:masterfrom
DaveCTurner:2019-08-01-wait-for-relocations-and-events

Conversation

@DaveCTurner
Copy link
Contributor

@DaveCTurner DaveCTurner commented Aug 1, 2019

Adds a waitForEvents(Priority.LANGUID) to the cluster health request in
ESIntegTestCase#waitForRelocation() to deal with the case that this health
request returns successfully despite the fact that there is a pending reroute task which
will relocate another shard.

Relates #44433
Fixes #45003
@DaveCTurner
Wait for events in waitForRelocation
95af91a 
Adds a `waitForEvents(Priority.LANGUID)` to the cluster health request in
`ESIntegTestCase#waitForRelocation()` to deal with the case that this health
request returns successfully despite the fact that there is a pending reroute task which
will relocate another shard.

Relates elastic#44433
Fixes elastic#45003
@DaveCTurner DaveCTurner added >test Issues or PRs that are addressing/adding tests :Distributed/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) v8.0.0 v7.4.0 labels Aug 1, 2019
@DaveCTurner DaveCTurner requested a review from ywelsch August 1, 2019 07:47
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 1, 2019

Pinging @elastic/es-distributed
@DaveCTurner
Copy link
Contributor Author

DaveCTurner commented Aug 1, 2019

I could not reproduce the failure reported in #45003 after repeated attempts, but this seems a likely explanation.

I forward-ported the muting of the test from #45003 to master so that I could remove it in this PR.
ywelsch
ywelsch approved these changes Aug 1, 2019
View reviewed changes
Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@DaveCTurner DaveCTurner merged commit 29235a6 into elastic:master Aug 1, 2019
@DaveCTurner DaveCTurner deleted the 2019-08-01-wait-for-relocations-and-events branch August 1, 2019 12:45
DaveCTurner added a commit that referenced this pull request Aug 1, 2019
@DaveCTurner
Wait for events in waitForRelocation (#45074)
c088baf 
Adds a `waitForEvents(Priority.LANGUID)` to the cluster health request in
`ESIntegTestCase#waitForRelocation()` to deal with the case that this health
request returns successfully despite the fact that there is a pending reroute task which
will relocate another shard.

Relates #44433
Fixes #45003
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) >test Issues or PRs that are addressing/adding tests v7.4.0 v8.0.0-alpha1

4 participants

@DaveCTurner @elasticmachine @ywelsch @jakelandis