You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The problem: missing events were represented as null values in intermediate states (before converting them to {missing: true} JSON), but in some circumstances events have to be serialized, eg. when executing an async search, and that caused a NPE.
The fix: this PR replaces the null placeholder with a constant Event instance to represent missing events, allowing proper serialization.
Backport details: In the main branch, the fix also includes a TransportVersion change to add the new "missing" attribute to the serialization. Since backporting this part is particularly tricky, here we are using a work-around to avoid a version increment: we'll consider events with _index: "" (empty index) as missing events; the missing attribute won't be serialized, preserving the existing serialization format.
.. Backport details: In the main branch, the fix also includes a TransportVersion change to add the new "missing" attribute to the serialization. Since backporting this part is particularly tricky, here we are using a work-around to avoid a version increment: we'll consider events with _index: "" (empty index) as missing events; the missing attribute won't be serialized, preserving the existing serialization format.
In this particular case, I agree that the workaround ( as you have described ) is the safer way to proceed, rather than trying to determine the Transport range to eliminate and individual checks to update in main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR backports #97718 to v 8.9.1
The problem: missing events were represented as null values in intermediate states (before converting them to {missing: true} JSON), but in some circumstances events have to be serialized, eg. when executing an async search, and that caused a NPE.
The fix: this PR replaces the null placeholder with a constant Event instance to represent missing events, allowing proper serialization.
Backport details: In the
mainbranch, the fix also includes a TransportVersion change to add the new "missing" attribute to the serialization. Since backporting this part is particularly tricky, here we are using a work-around to avoid a version increment: we'll consider events with_index: ""(empty index) as missing events; themissingattribute won't be serialized, preserving the existing serialization format.