[MarkdownEditor] Add className support to toolbar for custom styling#9349
Merged
weronikaolejniczak merged 3 commits intoelastic:mainfrom Feb 2, 2026
Merged
Conversation
|
👋 Since this is a community submitted pull request, a Buildkite build has not been started automatically. Would an Elastic organization member please verify the contents of this pull request and kick off a build manually? |
Contributor
There was a problem hiding this comment.
@ragini-pandey this filename needs to be: 9349.md, same as your PR number! 😄
Contributor
Author
There was a problem hiding this comment.
Ohk Thanks. I thought it was an issue number.
Renamed!
weronikaolejniczak
approved these changes
Feb 2, 2026
Contributor
weronikaolejniczak
left a comment
There was a problem hiding this comment.
The code looks as expected, let's see if the CI passes. If so, we're good to merge! Thank you for the contribution, @ragini-pandey 🙏🏻 💚
Contributor
|
buildkite test this |
Collaborator
💚 Build Succeeded |
Collaborator
💚 Build Succeeded
|
mgadewoll
added a commit
to elastic/kibana
that referenced
this pull request
Feb 10, 2026
## Dependency updates - `@elastic/eui`: v112.2.0 ⏩ v112.3.0 - `@elastic/eslint-plugin-eui`: v2.7.0 ⏩ v2.8.0 --- ## Package updates ### `@elastic/eui` [v112.3.0](https://github.com/elastic/eui/releases/tag/v112.3.0) - Added new `server` icon. ([#9355](elastic/eui#9355)) - Added `className` support to `EuiMarkdownEditor`'s `toolbarProps` for custom toolbar styling ([#9349](elastic/eui#9349)) - Updated `EuiFilePicker` to use the `upload` icon to better indicate uploads. ([#9351](elastic/eui#9351)) - Exported the flyout system store singleton and added an event observer for emitting close session events ([#9347](elastic/eui#9347)) - Updated `EuiIcon` to use standard dynamic imports for icon assets, enabling native support for modern bundlers (Rollup, Parcel) and improving initial load performance ([#9342](elastic/eui#9342)) **Bug fixes** - Fixed a potential crash in the flyout system: due to asynchronous state updates and React's batching behavior, it was possible to experience a crash when closing a managed flyout. ([#9356](elastic/eui#9356)) ### `@elastic/eslint-plugin-eui` v2.8.0 - Added new `icon-accessibility-rules` rule. ([#9357](elastic/eui#9357)) - Added new `badge-accessibility-rules` rule. ([#9354](elastic/eui#9354))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
classNamesupport to theEuiMarkdownEditortoolbar through thetoolbarPropsprop, allowing consumers to apply custom styles to the toolbar element.Changes
toolbarPropsto acceptclassNamein addition torightEuiMarkdownEditorToolbarto merge custom className with the defaulteuiMarkdownEditorToolbarclass usingclassNamesutilityUsage
Why are we making this change?
Closes #9153
In Kibana dashboards, there's a need to display very small markdown editors where hiding the toolbar is necessary. Currently, this is being done by targeting the element via
data-test-subj, but targeting via className is preferred for styling purposes. See related Kibana PR: elastic/kibana#240806Screenshots #
N/A - No visual changes. This adds a passthrough prop for custom styling.
Impact to users
Non-breaking change. This is an additive enhancement that allows users to pass a custom
classNameto the toolbar viatoolbarProps. Existing usage remains unaffected.Users who previously targeted the toolbar via
data-test-subj="euiMarkdownEditorToolbar"can now use a custom className instead:QA
General checklist
Checked in both light and dark modes(No visual changes)Checked in both MacOS and Windows high contrast modes(No visual changes)Checked in mobile(No visual changes)Checked in Chrome, Safari, Edge, and Firefox(No visual changes)Checked for accessibility including keyboard-only and screenreader modes(No accessibility impact)Added documentation(Props are self-documenting via TypeScript)@defaultif default values are missing) and playground togglesChecked Code Sandbox works for any docs examples(No new examples added)Updated visual regression tests(No visual changes)If applicable, added the breaking change issue label(Not a breaking change)If the changes unblock an issue in a different repo, smoke tested carefully(Minor enhancement)If applicable, file an issue to update EUI's Figma library(No UI changes)